linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: dtsi: imx6qdl-sabresd: Add USB host 1 VBUS regulator
Date: Fri, 9 Aug 2013 16:05:42 +0800	[thread overview]
Message-ID: <20130809080540.GA23876@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <CAOMZO5AXprz7MsxmyWB_nH8pc0GX3sbcZUtDqEVkf0W9myBbxA@mail.gmail.com>

On Thu, Aug 08, 2013 at 11:22:43PM -0300, Fabio Estevam wrote:
> On Thu, Aug 8, 2013 at 9:23 PM, Peter Chen <peter.chen@freescale.com> wrote:
> > We enabled USB host 1, so host 1's vbus should be on to let
> > host 1 work.
> >
> > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> > ---
> >  arch/arm/boot/dts/imx6qdl-sabresd.dtsi |   10 ++++++++++
> >  1 files changed, 10 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> > index 6e5dfdb..6e9d4d7 100644
> > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> > @@ -27,6 +27,15 @@
> >                         enable-active-high;
> >                 };
> >
> > +               reg_usb_h1_vbus: usb_h1_vbus {
> > +                       compatible = "regulator-fixed";
> > +                       regulator-name = "usb_h1_vbus";
> > +                       regulator-min-microvolt = <5000000>;
> > +                       regulator-max-microvolt = <5000000>;
> > +                       gpio = <&gpio1 29 0>;
> 
> You should also add en entry into pinctrl_hog for this gpio.
> 

Thanks, Fabio. What's the rule for adding gpio function for pinctrl
at dts? At pinctrl_hog or the device's pinctrl group?

-- 

Best Regards,
Peter Chen

  reply	other threads:[~2013-08-09  8:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09  0:23 [PATCH 1/1] ARM: dtsi: imx6qdl-sabresd: Add USB host 1 VBUS regulator Peter Chen
2013-08-09  2:22 ` Fabio Estevam
2013-08-09  8:05   ` Peter Chen [this message]
2013-08-09 11:27     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130809080540.GA23876@shlinux1.ap.freescale.net \
    --to=peter.chen@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).