From: pullip.cho@samsung.com (Cho KyongHo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 01/16] iommu/exynos: do not include removed header
Date: Fri, 09 Aug 2013 13:01:33 +0900 [thread overview]
Message-ID: <20130809130133.fea18aa350c831ece07188e3@samsung.com> (raw)
In-Reply-To: <21505674.fdNgPGp76O@amdc1227>
On Thu, 08 Aug 2013 15:42:24 +0200, Tomasz Figa wrote:
> Hi KyongHo,
>
> On Thursday 08 of August 2013 18:37:25 Cho KyongHo wrote:
> > This commit remove <mach/sysmmu.h> which is removed.
>
> I would prefer a more meaningful commit message, something among following
> lines:
>
> 8<---
> Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
> exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
> removing remaining use of it from exynos-iommu driver, thus causing a
> compilation error.
>
> This patch fixes the error by removing respective include line from exynos-
> iommu.c.
> --->8
>
Ok.
> Also a sentence explaining why linux/kernel.h header must be included would
> be nice.
>
> > Signed-off-by: Cho KyongHo <pullip.cho@samsung.com>
>
> Please note that as far as I'm aware of, tags should be made using western
> name writing convention, i.e. starting with first name.
>
Oh, I didn't think that the order of family/given names are the matter.
I don't care about changing the order.
Thanks.
KyongHo.
> Best regards,
> Tomasz
>
> > ---
> > drivers/iommu/exynos-iommu.c | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> > index 3f32d64..233f382 100644
> > --- a/drivers/iommu/exynos-iommu.c
> > +++ b/drivers/iommu/exynos-iommu.c
> > @@ -12,6 +12,7 @@
> > #define DEBUG
> > #endif
> >
> > +#include <linux/kernel.h>
> > #include <linux/io.h>
> > #include <linux/interrupt.h>
> > #include <linux/platform_device.h>
> > @@ -29,8 +30,6 @@
> > #include <asm/cacheflush.h>
> > #include <asm/pgtable.h>
> >
> > -#include <mach/sysmmu.h>
> > -
> > /* We does not consider super section mapping (16MB) */
> > #define SECT_ORDER 20
> > #define LPAGE_ORDER 16
prev parent reply other threads:[~2013-08-09 4:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 9:37 [PATCH v9 01/16] iommu/exynos: do not include removed header Cho KyongHo
2013-08-08 13:42 ` Tomasz Figa
2013-08-09 4:01 ` Cho KyongHo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809130133.fea18aa350c831ece07188e3@samsung.com \
--to=pullip.cho@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox