linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: KVM: Simplify tracepoint text
Date: Sun, 11 Aug 2013 20:41:49 -0700	[thread overview]
Message-ID: <20130812034149.GA5003@cbox> (raw)
In-Reply-To: <520698CD.2070904@cogentembedded.com>

On Sat, Aug 10, 2013 at 11:47:25PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 08/09/2013 07:41 AM, Christoffer Dall wrote:
> 
> >The tracepoint for kvm_guest_fault was extremely long, make it a
> >slightly bit shorter.
> 
> >Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> >---
> >  arch/arm/kvm/trace.h |    7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> >diff --git a/arch/arm/kvm/trace.h b/arch/arm/kvm/trace.h
> >index a8e73ed..8cbaea2 100644
> >--- a/arch/arm/kvm/trace.h
> >+++ b/arch/arm/kvm/trace.h
> >@@ -59,10 +59,9 @@ TRACE_EVENT(kvm_guest_fault,
> >  		__entry->ipa			= ipa;
> >  	),
> >
> >-	TP_printk("guest fault at PC %#08lx (hxfar %#08lx, "
> >-		  "ipa %#16llx, hsr %#08lx",
> >-		  __entry->vcpu_pc, __entry->hxfar,
> >-		  __entry->ipa, __entry->hsr)
> >+	TP_printk("ipa 0x%llx, hsr 0x%#08lx, hxfar 0x%#08lx, pc 0x%#08lx",
> 
>    "0x" and "#" are redundant, they mean the same thing, hexadecimal prefix.
> 
Duh, indeed, nicely spotted.  I'll respin.

Thanks,
-Christoffer

      reply	other threads:[~2013-08-12  3:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09  3:41 [PATCH] ARM: KVM: Simplify tracepoint text Christoffer Dall
2013-08-10 19:47 ` Sergei Shtylyov
2013-08-12  3:41   ` Christoffer Dall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130812034149.GA5003@cbox \
    --to=christoffer.dall@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).