From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: Build error: versatile express
Date: Mon, 12 Aug 2013 18:06:52 +0100 [thread overview]
Message-ID: <20130812170652.GF23006@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.03.1308121125420.14472@syhkavp.arg>
On Mon, Aug 12, 2013 at 12:55:23PM -0400, Nicolas Pitre wrote:
> On Mon, 12 Aug 2013, Dave Martin wrote:
>
> > On Mon, Aug 12, 2013 at 11:28:04AM +0100, Russell King - ARM Linux wrote:
> > > arch/arm/mach-vexpress/tc2_pm.c: In function 'tc2_pm_down.clone.0':
> > > arch/arm/mach-vexpress/tc2_pm.c:200:1: error: fp cannot be used in asm here
> > >
> > > This is caused by the assembly code in this file clobbering R11, which
> > > is incompatible with having CONFIG_FRAME_POINTER=y.
> >
> > Is there any reason not to fix this just by pushing/popping r11 inside
> > the asm and removing it from the clobber list?
>
> That's most likely the best fix. What about this?
>
> ---- >8
>
> From: Nicolas Pitre <nicolas.pitre@linaro.org>
> Date: Mon, 12 Aug 2013 12:47:13 -0400
> Subject: [PATCH] ARM: vexpress/MCPM: fix cache disable sequence when
> CONFIG_FRAME_POINTER=y
>
> If CONFIG_FRAME_POINTER=y we hget the following error:
>
> arch/arm/mach-vexpress/tc2_pm.c: In function 'tc2_pm_down':
> arch/arm/mach-vexpress/tc2_pm.c:200:1: error: fp cannot be used in asm here
>
> Let's fix that by explicitly preserving r11 on the stack and removing it
> from the clobber list.
>
> Reported-by: Russell King <linux@arm.linux.org.uk>
^^^^^^^^^^^^^^^^^^^^^^
rmk+kernel at arm.linux.org.uk please
next prev parent reply other threads:[~2013-08-12 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130812124801.GB2823@localhost.localdomain>
2013-08-12 16:55 ` Build error: versatile express Nicolas Pitre
2013-08-12 17:06 ` Russell King - ARM Linux [this message]
2013-08-12 17:11 ` Nicolas Pitre
2013-08-13 10:52 ` Dave Martin
2013-08-13 15:50 ` Nicolas Pitre
2013-08-15 9:58 ` Dave Martin
2013-08-12 10:28 Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812170652.GF23006@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).