From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes.
Date: Mon, 12 Aug 2013 10:15:04 -0700 [thread overview]
Message-ID: <20130812171504.GA31418@core.coreip.homeip.net> (raw)
In-Reply-To: <5203D487.5020507@wwwdotorg.org>
On Thu, Aug 08, 2013 at 11:25:27AM -0600, Stephen Warren wrote:
> On 08/08/2013 11:13 AM, Dmitry Torokhov wrote:
> > On Thu, Aug 08, 2013 at 10:41:20PM +0530, Laxman Dewangan wrote:
> >> On Wednesday 07 August 2013 12:58 AM, Stephen Warren wrote:
> >>> (CC'ing DT bindings maintainers too, hence quoting a bit of the patch)
> >>>
> >>> On 08/06/2013 08:12 AM, Laxman Dewangan wrote:
> >>>> Many of Key device tree bindings uses the constant number as key code
> >>>> which matches with kernel header key code and then comment as follows
> >>>> for reference/better readability:
> >>>> linux,code = <102>; /* KEY_HOME */
> >>>>
> >>>> Create a DT header which defines all the key code so that DT key bindings
> >>>> can use it as follows:
> >>>> linux,code = <KEY_HOME>;
> ...
> > I am uncomfortable that we are duplicating the whole list of keycodes
> > here. Do you think we could split keycodes and other event codes from
> > include/uapi/linux/input.h into include/uapi/linux/input-events.h and
> > unclude it directly into DTS?
>
> Device tree files can only include headers in include/dt-bindings.
> Eventually/soon, all the DT files and the headers in the dt-bindings/
> directory will be split out into a separate git tree, which does not
> have access to include/uapi, or indeed any other Linux kernel header files.
OK, that makes it easier for me - please merge through whatever tree
that owns include/dt-bindings.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2013-08-12 17:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 14:12 [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes Laxman Dewangan
2013-08-06 14:12 ` [PATCH 2/2] ARM: tegra: use dt-binding header for key code Laxman Dewangan
2013-08-06 19:28 ` Stephen Warren
2013-08-06 14:28 ` [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes Jason Cooper
2013-08-06 19:28 ` Stephen Warren
2013-08-08 17:11 ` Laxman Dewangan
2013-08-08 17:13 ` Dmitry Torokhov
2013-08-08 17:25 ` Stephen Warren
2013-08-12 17:15 ` Dmitry Torokhov [this message]
2013-08-12 17:59 ` Stephen Warren
2013-08-19 14:53 ` Laxman Dewangan
2013-08-19 16:24 ` Stephen Warren
2013-08-19 22:35 ` Rob Herring
2013-08-08 17:32 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812171504.GA31418@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).