From: Dave.Martin@arm.com (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: signal: sigreturn_codes should be endian neutral to work in BE8
Date: Tue, 13 Aug 2013 13:33:15 +0100 [thread overview]
Message-ID: <20130813123315.GD2823@localhost.localdomain> (raw)
In-Reply-To: <20130813121245.GK23006@n2100.arm.linux.org.uk>
On Tue, Aug 13, 2013 at 01:12:45PM +0100, Russell King - ARM Linux wrote:
> On Tue, Aug 13, 2013 at 12:12:11AM -0700, Victor Kamensky wrote:
> > In case of BE8 kernel data is in BE order whereas code stays in LE
> > order. sigreturn_codes array initializer need to use macros from
> > <asm/opcodes.h> to setup instructions code in endian neutral way.
> >
> > Problem was discovered during ltp testing of BE system: all rt_sig*
> > tests failed. Tested against the same tests in both BE and LE modes.
>
> It might make more sense to move these into a .S file actually.
That would make sense. Since the kernel assumes v4, I think we can
assume sufficiently Thumb-capable tools that all these instructions can
be assembled directly without needing magic numbers.
Then the swabbing should be correct in vmlinux with no extra effort.
Cheers
---Dave
next prev parent reply other threads:[~2013-08-13 12:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 7:12 [PATCH] ARM: signal: sigreturn_codes should be endian neutral to work in BE8 Victor Kamensky
2013-08-13 12:12 ` Russell King - ARM Linux
2013-08-13 12:33 ` Dave Martin [this message]
2013-08-13 14:59 ` Victor Kamensky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813123315.GD2823@localhost.localdomain \
--to=dave.martin@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).