From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave.Martin@arm.com (Dave Martin) Date: Thu, 15 Aug 2013 10:58:43 +0100 Subject: Build error: versatile express In-Reply-To: References: <20130812124801.GB2823@localhost.localdomain> <20130813105227.GC2823@localhost.localdomain> Message-ID: <20130815095836.GA2562@localhost.localdomain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Aug 13, 2013 at 11:50:17AM -0400, Nicolas Pitre wrote: > On Tue, 13 Aug 2013, Dave Martin wrote: > > > On Mon, Aug 12, 2013 at 12:55:23PM -0400, Nicolas Pitre wrote: > > > On Mon, 12 Aug 2013, Dave Martin wrote: > > > > > > > On Mon, Aug 12, 2013 at 11:28:04AM +0100, Russell King - ARM Linux wrote: > > > > > arch/arm/mach-vexpress/tc2_pm.c: In function 'tc2_pm_down.clone.0': > > > > > arch/arm/mach-vexpress/tc2_pm.c:200:1: error: fp cannot be used in asm here > > > > > > > > > > This is caused by the assembly code in this file clobbering R11, which > > > > > is incompatible with having CONFIG_FRAME_POINTER=y. > > > > > > > > Is there any reason not to fix this just by pushing/popping r11 inside > > > > the asm and removing it from the clobber list? > > > > > > That's most likely the best fix. What about this? > > > > Were we replacing these instances with the macro, or is that still in > > flight? > > I've updated the macro patch accordingly. I prefer to submit that one > separately. OK, sounds good Cheers ---Dave > > > Anyway, if useful: > > > > Reviewed-by: Dave Martin > > Thanks. > > > Nicolas > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel