* Build error: kvm/reset.c
@ 2013-08-15 11:41 Russell King - ARM Linux
2013-08-19 20:54 ` Christoffer Dall
0 siblings, 1 reply; 4+ messages in thread
From: Russell King - ARM Linux @ 2013-08-15 11:41 UTC (permalink / raw)
To: linux-arm-kernel
Last night's omap4430-sdp randconfig failed with this error in the KVM code:
arch/arm/kvm/reset.c:43:2: error: unknown field 'irq' specified in initializer
Configs etc at http://www.arm.linux.org.uk/developer/build/
Tree is my tip plus arm-soc tip plus Linus' tip.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Build error: kvm/reset.c
2013-08-15 11:41 Build error: kvm/reset.c Russell King - ARM Linux
@ 2013-08-19 20:54 ` Christoffer Dall
2013-08-19 21:07 ` Russell King - ARM Linux
0 siblings, 1 reply; 4+ messages in thread
From: Christoffer Dall @ 2013-08-19 20:54 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 15, 2013 at 12:41:50PM +0100, Russell King - ARM Linux wrote:
> Last night's omap4430-sdp randconfig failed with this error in the KVM code:
>
> arch/arm/kvm/reset.c:43:2: error: unknown field 'irq' specified in initializer
>
> Configs etc at http://www.arm.linux.org.uk/developer/build/
>
> Tree is my tip plus arm-soc tip plus Linus' tip.
hmmm, I'm wondering if this is actually related to:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676
Can you tell me which GCC version you are using?
I have been unable to reproduce this in any way (unfortunately it seems
the randconfig generating this error is also not available anymore), but
this patch may solve the issue:
diff --git a/arch/arm/kvm/reset.c b/arch/arm/kvm/reset.c
index b7840e7..71e08ba 100644
--- a/arch/arm/kvm/reset.c
+++ b/arch/arm/kvm/reset.c
@@ -40,7 +40,7 @@ static struct kvm_regs a15_regs_reset = {
};
static const struct kvm_irq_level a15_vtimer_irq = {
- .irq = 27,
+ { .irq = 27 },
.level = 1,
};
-Christoffer
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Build error: kvm/reset.c
2013-08-19 20:54 ` Christoffer Dall
@ 2013-08-19 21:07 ` Russell King - ARM Linux
2013-08-19 21:16 ` Christoffer Dall
0 siblings, 1 reply; 4+ messages in thread
From: Russell King - ARM Linux @ 2013-08-19 21:07 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 19, 2013 at 01:54:42PM -0700, Christoffer Dall wrote:
> On Thu, Aug 15, 2013 at 12:41:50PM +0100, Russell King - ARM Linux wrote:
> > Last night's omap4430-sdp randconfig failed with this error in the KVM code:
> >
> > arch/arm/kvm/reset.c:43:2: error: unknown field 'irq' specified in initializer
> >
> > Configs etc at http://www.arm.linux.org.uk/developer/build/
> >
> > Tree is my tip plus arm-soc tip plus Linus' tip.
>
>
> hmmm, I'm wondering if this is actually related to:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676
>
> Can you tell me which GCC version you are using?
4.5.4.
> I have been unable to reproduce this in any way (unfortunately it seems
> the randconfig generating this error is also not available anymore), but
> this patch may solve the issue:
>
> diff --git a/arch/arm/kvm/reset.c b/arch/arm/kvm/reset.c
> index b7840e7..71e08ba 100644
> --- a/arch/arm/kvm/reset.c
> +++ b/arch/arm/kvm/reset.c
> @@ -40,7 +40,7 @@ static struct kvm_regs a15_regs_reset = {
> };
>
> static const struct kvm_irq_level a15_vtimer_irq = {
> - .irq = 27,
> + { .irq = 27 },
> .level = 1,
> };
Yes, that appears to fix it with the test I just tried:
struct kvm_irq_level {
union {
unsigned irq;
int status;
};
unsigned level;
};
const struct kvm_irq_level a15_vtimer_irq = {
{ .irq = 15, },
.level = 1,
};
produces:
a15_vtimer_irq:
.word 15
.word 1
which is correct.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Build error: kvm/reset.c
2013-08-19 21:07 ` Russell King - ARM Linux
@ 2013-08-19 21:16 ` Christoffer Dall
0 siblings, 0 replies; 4+ messages in thread
From: Christoffer Dall @ 2013-08-19 21:16 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 19, 2013 at 10:07:20PM +0100, Russell King - ARM Linux wrote:
> On Mon, Aug 19, 2013 at 01:54:42PM -0700, Christoffer Dall wrote:
> > On Thu, Aug 15, 2013 at 12:41:50PM +0100, Russell King - ARM Linux wrote:
> > > Last night's omap4430-sdp randconfig failed with this error in the KVM code:
> > >
> > > arch/arm/kvm/reset.c:43:2: error: unknown field 'irq' specified in initializer
> > >
> > > Configs etc at http://www.arm.linux.org.uk/developer/build/
> > >
> > > Tree is my tip plus arm-soc tip plus Linus' tip.
> >
> >
> > hmmm, I'm wondering if this is actually related to:
> > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676
> >
> > Can you tell me which GCC version you are using?
>
> 4.5.4.
>
> > I have been unable to reproduce this in any way (unfortunately it seems
> > the randconfig generating this error is also not available anymore), but
> > this patch may solve the issue:
> >
> > diff --git a/arch/arm/kvm/reset.c b/arch/arm/kvm/reset.c
> > index b7840e7..71e08ba 100644
> > --- a/arch/arm/kvm/reset.c
> > +++ b/arch/arm/kvm/reset.c
> > @@ -40,7 +40,7 @@ static struct kvm_regs a15_regs_reset = {
> > };
> >
> > static const struct kvm_irq_level a15_vtimer_irq = {
> > - .irq = 27,
> > + { .irq = 27 },
> > .level = 1,
> > };
>
> Yes, that appears to fix it with the test I just tried:
>
> struct kvm_irq_level {
> union {
> unsigned irq;
> int status;
> };
> unsigned level;
> };
>
> const struct kvm_irq_level a15_vtimer_irq = {
> { .irq = 15, },
> .level = 1,
> };
>
> produces:
>
> a15_vtimer_irq:
> .word 15
> .word 1
>
> which is correct.
Thanks,
I'll queue this patch.
-Christoffer
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-19 21:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-15 11:41 Build error: kvm/reset.c Russell King - ARM Linux
2013-08-19 20:54 ` Christoffer Dall
2013-08-19 21:07 ` Russell King - ARM Linux
2013-08-19 21:16 ` Christoffer Dall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).