public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: ludovic.desroches@atmel.com (Ludovic Desroches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: at91: at91sam9260: add missing pinctrl on mmc
Date: Wed, 21 Aug 2013 10:56:01 +0200	[thread overview]
Message-ID: <20130821085601.GH5149@ludovic.desroches@atmel.com> (raw)
In-Reply-To: <52147553.2010305@atmel.com>

On Wed, Aug 21, 2013 at 10:07:47AM +0200, Nicolas Ferre wrote:
> On 21/08/2013 09:42, ludovic.desroches at atmel.com :
> >From: Ludovic Desroches <ludovic.desroches@atmel.com>
> >
> >pinctrl-names was missing causing mmc pinctrl to never be requested. Moreover,
> >add minimal pin configuration to not cause error if overloading is forgotten
> >in board files.
> >
> >Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> >Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> 
> (modified the "interrupts" property to add the macro definition).
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

After discussing with Jean-Christophe keeping the first version of the patch
seems a better choice because the user will be notified if he forgets to
overload pin configuration instead of thinking that everything goes right and
having a default pin configuration that could not fit its configuration.

> 
> stacked in at91-3.12-dt.
> 
> Due to macro change, I can't tag it for -stable. We have to remember
> to add it when it is accepted upstream.
> 
> thanks.
> 
> >---
> >
> >v2:
> >   - add minimal pin configuration
> >
> >  arch/arm/boot/dts/at91sam9260.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
> >index 84c4bef..b4de52a 100644
> >--- a/arch/arm/boot/dts/at91sam9260.dtsi
> >+++ b/arch/arm/boot/dts/at91sam9260.dtsi
> >@@ -477,6 +477,8 @@
> >  				interrupts = <9 4 0>;
> >  				#address-cells = <1>;
> >  				#size-cells = <0>;
> >+				pinctrl-names = "default";
> >+				pinctrl-0 = <&pinctrl_mmc0_clk &pinctrl_mmc0_slot1_cmd_dat0>;
> >  				status = "disabled";
> >  			};
> >
> >
> 
> 
> -- 
> Nicolas Ferre

  reply	other threads:[~2013-08-21  8:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21  7:42 [PATCH v2] ARM: at91: at91sam9260: add missing pinctrl on mmc ludovic.desroches at atmel.com
2013-08-21  8:07 ` Nicolas Ferre
2013-08-21  8:56   ` Ludovic Desroches [this message]
2013-08-21  9:10     ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130821085601.GH5149@ludovic.desroches@atmel.com \
    --to=ludovic.desroches@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox