From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Wed, 21 Aug 2013 18:52:27 +0100 Subject: [PATCH v3 4/6] ARM64: arch_timer: configure and enable event stream In-Reply-To: <1377018526-9832-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> References: <1376414984-14182-5-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1377018526-9832-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> Message-ID: <20130821175227.GH1653@mudshark.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sudeep, On Tue, Aug 20, 2013 at 06:08:46PM +0100, Sudeep KarkadaNagesha wrote: > From: Sudeep KarkadaNagesha > > This patch configures the event stream frequency and enables it. > It also adds the hwcaps as well as compat-specific definitions to > the user to detect this event stream feature. > > Cc: Catalin Marinas > Reviewed-by: Lorenzo Pieralisi > Signed-off-by: Will Deacon > [sudeep: moving ARM/ARM64 changes into separate patches] > Signed-off-by: Sudeep KarkadaNagesha > --- > arch/arm64/include/asm/arch_timer.h | 15 +++++++++++++-- > arch/arm64/include/asm/hwcap.h | 7 ++++++- > arch/arm64/include/uapi/asm/hwcap.h | 1 + > arch/arm64/kernel/setup.c | 6 ++++++ > 4 files changed, 26 insertions(+), 3 deletions(-) > > Hi Will, > > This is modified version enabling timer event stream hwcap compat dynamically. > Let me know if this looks fine. Looks pretty good to me, one minor comment: > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index add6ea6..91af65a 100644 > --- a/arch/arm64/kernel/setup.c > +++ b/arch/arm64/kernel/setup.c > @@ -60,6 +60,11 @@ EXPORT_SYMBOL(processor_id); > unsigned int elf_hwcap __read_mostly; > EXPORT_SYMBOL_GPL(elf_hwcap); > > +#ifdef CONFIG_COMPAT > +unsigned int compat_dyn_elf_hwcap __read_mostly = 0; > +EXPORT_SYMBOL_GPL(compat_dyn_elf_hwcap); > +#endif Given that the arch timer is the only user of this at the moment, and cannot be built as a module, I don't think we should bother exporting the symbol until it's actually required. Will