From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2: add type cast from 'unsigned' to 'signed'
Date: Thu, 22 Aug 2013 00:14:02 -0700 [thread overview]
Message-ID: <20130822071402.GQ7656@atomide.com> (raw)
In-Reply-To: <521479B4.8030604@asianux.com>
* Chen Gang <gang.chen@asianux.com> [130821 01:34]:
> Need add type cast, or can not notice the failure. The related warning
> (allmodconfig, "EXTRA_CFLAGS=-W"):
>
> arch/arm/mach-omap2/gpmc.c:728:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arm/mach-omap2/gpmc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index f3fdd6a..62377b5 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -725,7 +725,7 @@ static int gpmc_setup_irq(void)
> return -EINVAL;
>
> gpmc_irq_start = irq_alloc_descs(-1, 0, GPMC_NR_IRQ, 0);
> - if (gpmc_irq_start < 0) {
> + if ((signed)gpmc_irq_start < 0) {
> pr_err("irq_alloc_descs failed\n");
> return gpmc_irq_start;
> }
Hmm shouldn't we just have int gpmc_irq_start instead
of unsigned gpmc_irq_start?
Regards,
Tony
next prev parent reply other threads:[~2013-08-22 7:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 8:26 [PATCH] ARM: OMAP2: add type cast from 'unsigned' to 'signed' Chen Gang
2013-08-21 8:31 ` [PATCH] ARM: OMAP2: remove useless variable 'ret' Chen Gang
2013-08-22 7:17 ` Tony Lindgren
2013-08-22 7:24 ` Chen Gang
[not found] ` <52147E12.4060401@asianux.com>
2013-08-22 7:45 ` [Suggestion] ARM: allmodconfig: about cross compiling failure under i386 ubuntu Tony Lindgren
2013-08-22 9:19 ` Chen Gang
2013-08-22 10:15 ` Chen Gang
2013-08-22 10:22 ` Russell King - ARM Linux
2013-08-23 1:47 ` Chen Gang
2013-08-23 2:06 ` Chen Gang
2013-08-23 3:04 ` [PATCH] ARM: VExpress: Kconfig: avoid arm6 compatible for ARCH_VEXPRESS Chen Gang
2013-08-23 3:12 ` Chen Gang
2013-08-23 5:51 ` Tony Lindgren
2013-08-23 7:02 ` Chen Gang
2013-08-23 7:15 ` Chen Gang
2013-08-23 8:02 ` [PATCH v2] ARM: VExpress: Makefile: add armv7 flags for inline assmembly code compiling Chen Gang
2013-08-23 8:12 ` Chen Gang
2013-09-23 1:50 ` [PATCH v3] " Chen Gang
2013-08-22 7:14 ` Tony Lindgren [this message]
2013-08-22 7:43 ` [PATCH] ARM: OMAP2: add type cast from 'unsigned' to 'signed' Chen Gang
2013-08-22 7:47 ` [PATCH v2] ARM: OMAP2: use 'int' instead of 'unsigned' for variable 'gpmc_irq_start' Chen Gang
2013-08-22 7:57 ` Tony Lindgren
2013-08-22 8:01 ` Chen Gang
2013-08-22 8:32 ` Tony Lindgren
2013-08-22 8:59 ` Chen Gang F T
2013-08-23 5:48 ` Tony Lindgren
2013-08-23 6:14 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822071402.GQ7656@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).