From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/3] i2c-mv64xxx: Add I2C Transaction Generator support
Date: Thu, 22 Aug 2013 11:06:47 +0200 [thread overview]
Message-ID: <20130822090647.GA3491@katana> (raw)
In-Reply-To: <5215C07D.7040000@free-electrons.com>
> >> @@ -326,6 +463,12 @@ mv64xxx_i2c_do_action(struct mv64xxx_i2c_data *drv_data)
> >> drv_data->reg_base + drv_data->reg_offsets.control);
> >> break;
> >>
> >> + case MV64XXX_I2C_ACTION_OFFLOAD_SEND_START:
> >> + if (mv64xxx_i2c_offload_msg(drv_data) <= 0)
> >
> > needs to be adjusted when using -EINVAL above. I'd prefer the error case
> > in the else branch, though. Easier to read.
> >
>
> OK, but in this case ...
>
> >> + break;
> >> + else
> >> + drv_data->action = MV64XXX_I2C_ACTION_SEND_START;
> >> + /* FALLTHRU */
>
> ... the fall through here is less readable. But it is a matter of
> taste, I will change this.
Ah, I see. Well, try both and decide.
Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130822/3a92435b/attachment-0001.sig>
next prev parent reply other threads:[~2013-08-22 9:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 9:05 [PATCH v5 0/3] i2c-mv64xxx: Fixes and new feature for controlers embedded in Aramda XP Gregory CLEMENT
2013-08-09 9:05 ` [PATCH v5 1/3] i2c-mv64xxx: Add I2C Transaction Generator support Gregory CLEMENT
2013-08-15 12:13 ` Wolfram Sang
2013-08-20 15:56 ` Gregory CLEMENT
2013-08-21 21:01 ` Wolfram Sang
2013-08-22 7:40 ` Gregory CLEMENT
2013-08-22 9:06 ` Wolfram Sang [this message]
2013-08-09 9:05 ` [PATCH v5 2/3] i2c-mv64xxx: Fix timing issue on Armada XP (errata FE-8471889) Gregory CLEMENT
2013-08-09 9:05 ` [PATCH v5 3/3] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c Gregory CLEMENT
2013-08-09 9:13 ` Ezequiel Garcia
2013-08-09 9:18 ` Gregory CLEMENT
2013-08-09 9:30 ` Ezequiel Garcia
2013-08-09 11:32 ` Jason Cooper
2013-08-20 16:21 ` [PATCH v5 0/3] i2c-mv64xxx: Fixes and new feature for controlers embedded in Aramda XP Gregory CLEMENT
2013-08-20 19:07 ` Wolfram Sang
2013-08-21 10:44 ` Gregory CLEMENT
2013-08-21 13:43 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822090647.GA3491@katana \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).