From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Thu, 22 Aug 2013 14:49:30 +0100 Subject: [PATCH 09/33] ARM: ux500: Supply the I2C clocks lookup to the DBX500 DT In-Reply-To: <20130822133730.GB23152@e106331-lin.cambridge.arm.com> References: <1370521041-32318-1-git-send-email-lee.jones@linaro.org> <1370521041-32318-10-git-send-email-lee.jones@linaro.org> <20130820093034.GL31036@pengutronix.de> <20130822133730.GB23152@e106331-lin.cambridge.arm.com> Message-ID: <20130822134930.GA17154@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 22 Aug 2013, Mark Rutland wrote: > On Tue, Aug 20, 2013 at 10:30:34AM +0100, Sascha Hauer wrote: > > On Tue, Aug 20, 2013 at 11:11:19AM +0200, Linus Walleij wrote: > > > On Thu, Jun 6, 2013 at 2:16 PM, Lee Jones wrote: > > > > > > > +++ b/arch/arm/boot/dts/dbx5x0.dtsi > > > > @@ -572,6 +572,8 @@ > > > > v-i2c-supply = <&db8500_vape_reg>; > > > > > > > > clock-frequency = <400000>; > > > > + clocks = <&prcc_kclk 3 3>, <&prcc_pclk 3 3>; > > > > + clock-names = "nmk-i2c.0", "apb_pclk"; > > > > Why do most clocks in this series have the instance number in the clock > > names? This looks very wrong to me. > > +1. The clock names should be the input names to the unit, they > shouldn't vary per instance. Duly noted. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog