linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM
Date: Fri, 23 Aug 2013 09:36:13 +0200	[thread overview]
Message-ID: <20130823073612.GB3535@ulmo> (raw)
In-Reply-To: <20130822062610.GR31036@pengutronix.de>

On Thu, Aug 22, 2013 at 08:26:10AM +0200, Sascha Hauer wrote:
> On Thu, Aug 22, 2013 at 02:55:42AM +0000, Xiubo Li-B47053 wrote:
> > Hi Tomasz,
> > 
> > Thanks for your comments.
> > 
> > 
> > > Could you explain meaning of this property more precisely? I'm interested
> > > especially how is this related to the PWM IP block and boards.
> > > 
> > 
> > Yes.
> > There are 8 channels most. While the pinctrls of 4th and 5th channels could be
> > used by uart's Rx and Tx, then these 2 channels won't be used for pwm output,
> > so there will be 6 channels available by the pwm.
> > Thus, the pwm chip will register only 6 pwms(6 channels) most("fsl,pwm-channel-orders
> > = {0 1 2 3 6 7}").And also the "fsl,pwm-channel-number" will be 6.
> 
> If the chip has eight PWMs I would register all of them. If some of them
> are not routed out by the pinmux then just nothing happens if you use
> them. In a sane devicetree they won't be referenced anyway when they are
> not routed out of the SoC.

In that case, shouldn't this be hooked up to the pinctrl subsystem as
well? As I understand the above, the logical thing would be for each PWM
channel's .request() operation to configure the pinmuxing appropriately.
And if it can't be configured as necessary then .request() should return
an error (or propagate the error from the pinctrl subsystem).

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130823/be8cb051/attachment-0001.sig>

  parent reply	other threads:[~2013-08-23  7:36 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21  3:07 [PATCH 0/4] Add freescale ftm pwm driver for Vybrid VF610 TOWER Xiubo Li
2013-08-21  3:07 ` [PATCH 1/4] pwm: add freescale ftm pwm driver support Xiubo Li
2013-08-21  7:36   ` Sascha Hauer
2013-08-21  9:24     ` Xiubo Li-B47053
2013-08-21  9:50       ` Sascha Hauer
2013-08-21 10:46         ` Xiubo Li-B47053
2013-08-23  7:58         ` Thierry Reding
2013-08-23  9:05   ` Thierry Reding
2013-08-26  7:32     ` Xiubo Li-B47053
2013-08-27  7:40       ` Thierry Reding
2013-08-27  9:56         ` Xiubo Li-B47053
2013-08-21  3:07 ` [PATCH 2/4] ARM: dts: Add Freescale ftm pwm node for VF610 Xiubo Li
2013-08-23  9:13   ` Thierry Reding
2013-08-26  5:58     ` Xiubo Li-B47053
2013-08-21  3:07 ` [PATCH 3/4] ARM: dts: Enables ftm pwm device for Vybrid VF610 TOWER board Xiubo Li
2013-08-23  9:13   ` Thierry Reding
2013-08-26  6:00     ` Xiubo Li-B47053
2013-08-21  3:07 ` [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM Xiubo Li
2013-08-21 19:30   ` Tomasz Figa
2013-08-22  2:55     ` Xiubo Li-B47053
2013-08-22  6:26       ` Sascha Hauer
2013-08-22  7:32         ` Xiubo Li-B47053
2013-08-23  7:36         ` Thierry Reding [this message]
2013-08-23 19:29           ` Stephen Warren
2013-08-26  5:35             ` Xiubo Li-B47053
2013-08-26 20:01               ` Stephen Warren
2013-08-27  3:48                 ` Xiubo Li-B47053
2013-08-27  4:04                   ` Stephen Warren
2013-08-26  5:46           ` Xiubo Li-B47053
2013-08-22  8:25       ` Tomasz Figa
2013-08-22  9:52         ` Xiubo Li-B47053
2013-08-22 12:17           ` Tomasz Figa
2013-08-23  8:04         ` Thierry Reding
2013-08-23  9:10   ` Thierry Reding
2013-08-23 19:36     ` Stephen Warren
2013-08-30 19:19   ` Kumar Gala
2013-08-30 20:11     ` Stephen Warren
2013-09-03  5:25       ` Xiubo Li-B47053
2013-09-02  2:18     ` Xiubo Li-B47053

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130823073612.GB3535@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).