From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] clocksource: orion: Use atomic access for shared registers
Date: Fri, 23 Aug 2013 13:38:57 +0300 [thread overview]
Message-ID: <20130823103857.GP4600@tarshish> (raw)
In-Reply-To: <1377253445-2842-3-git-send-email-ezequiel.garcia@free-electrons.com>
Hi Ezequiel,
On Fri, Aug 23, 2013 at 07:24:04AM -0300, Ezequiel Garcia wrote:
> Replace the driver-specific thread-safe shared register API
> by the recently introduced atomic_io_clear_set().
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
[...]
> @@ -131,7 +121,9 @@ static void __init orion_timer_init(struct device_node
> *np)
> /* setup timer0 as free-running clocksource */
> writel(~0, timer_base + TIMER0_VAL);
> writel(~0, timer_base + TIMER0_RELOAD);
> - orion_timer_ctrl_clrset(0, TIMER0_RELOAD_EN | TIMER0_EN);
> + oatomic_io_modify(timer_base + TIMER_CTRL,
oatomic? Are you sure this code builds?
baruch
> + TIMER0_RELOAD_EN | TIMER0_EN,
> + TIMER0_RELOAD_EN | TIMER0_EN);
> clocksource_mmio_init(timer_base + TIMER0_VAL, "orion_clocksource",
> clk_get_rate(clk), 300, 32,
> clocksource_mmio_readl_down);
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2013-08-23 10:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 10:24 [PATCH v3 0/3] Introduce atomic MMIO register modify Ezequiel Garcia
2013-08-23 10:24 ` [PATCH v3 1/3] ARM: Introduce atomic MMIO modify Ezequiel Garcia
2013-08-23 10:38 ` Baruch Siach
2013-08-23 11:07 ` Ezequiel Garcia
2013-08-23 11:32 ` Ezequiel Garcia
2013-08-23 11:48 ` Catalin Marinas
2013-08-30 9:08 ` Will Deacon
2013-08-30 9:15 ` Catalin Marinas
2013-08-30 9:20 ` Will Deacon
2013-08-30 10:03 ` Catalin Marinas
2013-08-30 20:08 ` Jason Gunthorpe
2013-08-30 22:18 ` Russell King - ARM Linux
2013-09-05 8:59 ` Gregory CLEMENT
2013-09-05 9:08 ` Will Deacon
2013-09-05 9:20 ` Gregory CLEMENT
2013-09-06 16:48 ` Jason Gunthorpe
2013-08-23 11:28 ` Ezequiel Garcia
2013-08-23 10:24 ` [PATCH v3 2/3] clocksource: orion: Use atomic access for shared registers Ezequiel Garcia
2013-08-23 10:38 ` Baruch Siach [this message]
2013-08-23 10:49 ` Ezequiel Garcia
2013-08-23 10:24 ` [PATCH v3 3/3] watchdog: " Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130823103857.GP4600@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox