linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: SHMobile Compatibility String Inconsistencies
Date: Sat, 24 Aug 2013 12:13:23 +1000	[thread overview]
Message-ID: <20130824021323.GC5181@verge.net.au> (raw)
In-Reply-To: <1721850.l3ebodSrXr@avalon>

On Fri, Aug 23, 2013 at 01:31:31PM +0200, Laurent Pinchart wrote:
> Hi David,
> 
> On Friday 23 August 2013 12:11:11 David Gibson wrote:
> > On Thu, Aug 22, 2013 at 02:46:40PM +0900, Simon Horman wrote:
> > > Hi Laurent, Hi Guennadi, Hi All,
> > > 
> > > Olof has brought to my attention that there is some inconsistency
> > > in the way that compatibility strings for SHMobile are named and he
> > > has asked us to clean things up for v3.12.
> > > 
> > > Looking through arch/arm/boot/dts/ I see that we have:
> > > 
> > > 1. {gpio,pfc}-r8aXXXX and;
> > > 2. r8aXXXX-sdhi
> > > 
> > > The inconsistency that Olof has asked us to resolve is that we
> > > should either use r8aXXXX- or -r8aXXXX. Not both.
> > > 
> > > It seems to me that neither option is inherently better than the other
> > > so we should just choose the path of least resistance to make things
> > > consistent.
> > > 
> > > Laurent, Guennadi, do you have any opinions on if it would
> > > be easier to change the GPIO and PFC compatibility strings;
> > > or to change the SDHI compatibility strings?
> > > 
> > > Ideally I would like you to come to some sort of consensus and send
> > > patches.
> > 
> > So, by all means clean this up in the dts.
> > 
> > BUT, in keeping with the recent discussions on improving the DT
> > process, the corresponding drivers must continue to recognize both
> > forms, so that old DTs will still work correctly.
> 
> Given the early state of DT support in arm/mach-shmobile, I'm pretty sure we 
> have no DT-based systems in the wild. The old compatibility string could in my 
> opinion just be dropped.

I tend to agree, though I don't mind either way.

> > It's probably also worth putting a note about the deprecated form into
> > the binding description, too.
> 
> -- 
> Regards,
> 
> Laurent Pinchart

  reply	other threads:[~2013-08-24  2:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22  5:46 SHMobile Compatibility String Inconsistencies Simon Horman
2013-08-22 10:43 ` Laurent Pinchart
2013-08-23  0:19   ` Simon Horman
2013-08-27 17:34     ` Olof Johansson
2013-08-23  2:11 ` David Gibson
2013-08-23 11:31   ` Laurent Pinchart
2013-08-24  2:13     ` Simon Horman [this message]
2013-08-26 16:08       ` Guennadi Liakhovetski
2013-08-27  6:30         ` Laurent Pinchart
2013-08-27  6:46           ` Guennadi Liakhovetski
2013-08-26  7:16     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130824021323.GC5181@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).