From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 02/10] clk: sunxi: fix initialization of basic clocks
Date: Sun, 25 Aug 2013 14:50:08 -0700 [thread overview]
Message-ID: <20130825215008.8231.41811@quantum> (raw)
In-Reply-To: <1375609657-15434-3-git-send-email-maxime.ripard@free-electrons.com>
Quoting Maxime Ripard (2013-08-04 02:47:29)
> From: Emilio L?pez <emilio@elopez.com.ar>
>
> With the recent move towards CLK_OF_DECLARE(...), the driver stopped
> initializing osc32k, which is compatible "fixed-clock". This is because
> we never called of_clk_init(NULL). Fix this by moving the only other
> simple clock (osc24M) to use CLK_OF_DECLARE(...) and call of_clk_init(NULL)
> to initialize both of them.
>
> Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Mike Turquette <mturquette@linaro.org>
Taken into clk-next.
Regards,
Mike
> ---
> drivers/clk/sunxi/clk-sunxi.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index db1c45b..567963f 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -69,6 +69,7 @@ static void __init sunxi_osc_clk_setup(struct device_node *node)
> clk_register_clkdev(clk, clk_name, NULL);
> }
> }
> +CLK_OF_DECLARE(sunxi_osc, "allwinner,sun4i-osc-clk", sunxi_osc_clk_setup);
>
>
>
> @@ -422,12 +423,6 @@ static void __init sunxi_gates_clk_setup(struct device_node *node,
> of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
> }
>
> -/* Matches for of_clk_init */
> -static const __initconst struct of_device_id clk_match[] = {
> - {.compatible = "allwinner,sun4i-osc-clk", .data = sunxi_osc_clk_setup,},
> - {}
> -};
> -
> /* Matches for factors clocks */
> static const __initconst struct of_device_id clk_factors_match[] = {
> {.compatible = "allwinner,sun4i-pll1-clk", .data = &pll1_data,},
> @@ -482,8 +477,8 @@ static void __init of_sunxi_table_clock_setup(const struct of_device_id *clk_mat
>
> void __init sunxi_init_clocks(void)
> {
> - /* Register all the simple sunxi clocks on DT */
> - of_clk_init(clk_match);
> + /* Register all the simple and basic clocks on DT */
> + of_clk_init(NULL);
>
> /* Register factor clocks */
> of_sunxi_table_clock_setup(clk_factors_match, sunxi_factors_clk_setup);
> --
> 1.8.3.4
next prev parent reply other threads:[~2013-08-25 21:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-04 9:47 [PATCHv3 00/10] ARM: sunxi: Add support for the Allwinner A31 SoC Maxime Ripard
2013-08-04 9:47 ` [PATCHv3 01/10] irqchip: GIC: Add Cortex-A7 compatible string Maxime Ripard
2013-08-12 8:15 ` Maxime Ripard
2013-08-04 9:47 ` [PATCHv3 02/10] clk: sunxi: fix initialization of basic clocks Maxime Ripard
2013-08-12 8:17 ` Maxime Ripard
2013-08-25 21:50 ` Mike Turquette [this message]
2013-08-04 9:47 ` [PATCHv3 03/10] ARM: sunxi: Add the Allwinner A31 compatible to the machine definition Maxime Ripard
2013-08-04 9:47 ` [PATCHv3 04/10] ARM: sun6i: Add restart code for the A31 Maxime Ripard
2013-08-04 9:47 ` [PATCHv3 05/10] ARM: sunxi: Add Allwinner A31 DTSI Maxime Ripard
2013-08-04 9:47 ` [PATCHv3 06/10] ARM: sun6i: Add WITS Colombus A31 evaluation kit support Maxime Ripard
2013-08-04 9:47 ` [PATCHv3 07/10] pinctrl: sunxi: Add Allwinner A31 pins set Maxime Ripard
2013-08-12 8:19 ` Maxime Ripard
2013-08-19 11:22 ` Maxime Ripard
2013-08-21 21:45 ` Linus Walleij
2013-08-04 9:47 ` [PATCHv3 08/10] ARM: sunxi: dt: Add PIO controller to A31 DTSI Maxime Ripard
2013-08-04 9:47 ` [PATCHv3 09/10] ARM: sun6i: Add UART0 muxing options Maxime Ripard
2013-08-04 9:47 ` [PATCHv3 10/10] ARM: sun6i: colombus: Add uart0 muxing Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130825215008.8231.41811@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).