From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/9] watchdog: orion: Update device-tree binding documentation
Date: Tue, 27 Aug 2013 10:39:07 +0200 [thread overview]
Message-ID: <20130827103907.0030c970@skate> (raw)
In-Reply-To: <20130827083603.GA2286@localhost>
Dear Ezequiel Garcia,
On Tue, 27 Aug 2013 05:36:04 -0300, Ezequiel Garcia wrote:
> > Is there a reason we're going this route over adding a new compatible
> > string?
>
> Well, it seemed to me that this register splitting was more device-treeish:
> it prevents you from fixing your driver, adding a new compatible-string,
> and rebuilding a kernel each time a new SoC appears with a different offset
> between registers.
I don't think encoding register offsets in the DT is a good idea. The
compatible string is here to identify different revisions/versions of
the same hardware block, and the driver should abstract out the
details. Otherwise, you'll start encoding bit numbers, mask values, and
other crazy things in the Device Tree.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-08-27 8:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 22:12 [PATCH v2 0/9] Orion watchdog DT changes to support more SoCs Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 1/9] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 2/9] watchdog: orion: Make counter register a separate resource Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 3/9] ARM: orion: Assert watchdog RSTOUT enable bit Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 4/9] watchdog: orion: Remove RSTOUT bit enable/disable Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 5/9] watchdog: orion: Allow to build in any Orion platform Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 6/9] watchdog: orion: Rename device-tree binding documentation Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 7/9] watchdog: orion: Update " Ezequiel Garcia
2013-08-26 14:08 ` Jason Cooper
2013-08-27 8:36 ` Ezequiel Garcia
2013-08-27 8:39 ` Thomas Petazzoni [this message]
2013-08-27 11:13 ` Jason Cooper
2013-08-27 21:44 ` Stephen Warren
2013-08-23 22:12 ` [PATCH v2 8/9] ARM: kirkwood: Update watchdog 'reg' property Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 9/9] ARM: orion5x: Update orion-wdt DT node Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827103907.0030c970@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).