From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] DMA: let filter functions of of_dma_simple_xlate possible check of_node
Date: Wed, 28 Aug 2013 11:07:34 +0530 [thread overview]
Message-ID: <20130828053734.GH2748@intel.com> (raw)
In-Reply-To: <3565907.5flGSRLgMJ@wuerfel>
On Mon, Aug 26, 2013 at 08:15:17PM +0200, Arnd Bergmann wrote:
> On Monday 26 August 2013 19:40:57 Vinod Koul wrote:
> > And the selection should be done for the cases where you dont have programmable
> > mux in dmac. For programmable ones passing slave_id in dma_slave_config should
> > be fine.
>
> I think passing a slave_id from the slave driver is never correct with DT,
> since the ID is a property of the system rather than the slave device, so
> the driver has no access to it. Drivers have to always take the settings
> from DT and ignore what dma_slave_config() sets later.
Shouldnt slave id be property of the client driver. That way we can pass it to
the driver using dma_slave_config(). That should make it right..
~Vinod
--
next prev parent reply other threads:[~2013-08-28 5:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 2:00 [PATCH] DMA: let filter functions of of_dma_simple_xlate possible check of_node Richard Zhao
2013-08-02 12:06 ` Santosh Shilimkar
2013-08-02 20:52 ` Stephen Warren
2013-08-22 5:19 ` Richard Zhao
2013-08-22 20:18 ` Stephen Warren
2013-08-23 1:29 ` Richard Zhao
2013-08-23 15:57 ` Stephen Warren
2013-08-26 12:17 ` Laurent Pinchart
2013-08-26 12:55 ` Richard Zhao
2013-08-26 13:18 ` Laurent Pinchart
2013-08-26 14:10 ` Vinod Koul
2013-08-26 18:15 ` Arnd Bergmann
2013-08-28 5:37 ` Vinod Koul [this message]
2013-08-26 14:49 ` Richard Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828053734.GH2748@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).