From mboxrd@z Thu Jan  1 00:00:00 1970
From: vinod.koul@intel.com (Vinod Koul)
Date: Wed, 28 Aug 2013 11:07:34 +0530
Subject: [PATCH] DMA: let filter functions of of_dma_simple_xlate
 possible check of_node
In-Reply-To: <3565907.5flGSRLgMJ@wuerfel>
References: <1375408800-11789-1-git-send-email-rizhao@nvidia.com>
 <2811939.DFy94j5OEx@avalon> <20130826141057.GQ2748@intel.com>
 <3565907.5flGSRLgMJ@wuerfel>
Message-ID: <20130828053734.GH2748@intel.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Mon, Aug 26, 2013 at 08:15:17PM +0200, Arnd Bergmann wrote:
> On Monday 26 August 2013 19:40:57 Vinod Koul wrote:
> > And the selection should be done for the cases where you dont have programmable
> > mux in dmac. For programmable ones passing slave_id in dma_slave_config should
> > be fine.
> 
> I think passing a slave_id from the slave driver is never correct with DT,
> since the ID is a property of the system rather than the slave device, so
> the driver has no access to it. Drivers have to always take the settings
> from DT and ignore what dma_slave_config() sets later.
Shouldnt slave id be property of the client driver. That way we can pass it to
the driver using dma_slave_config(). That should make it right..

~Vinod

--