linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: shmobile: lager: Do not use register_type field of struct sh_eth_plat_data
@ 2013-08-22  7:36 Simon Horman
  2013-08-28 18:24 ` Olof Johansson
  2013-09-10  0:26 ` Olof Johansson
  0 siblings, 2 replies; 5+ messages in thread
From: Simon Horman @ 2013-08-22  7:36 UTC (permalink / raw)
  To: linux-arm-kernel

As of 8d3214c ("sh_eth: remove 'register_type' field from 'struct
sh_eth_plat_data'") is is no longer necessary or correct to use the
'register_type' field from 'struct sh_eth_plat_data' and doing so results
in a build error.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

---

Olof,

as discussed, please apply this to for-next and merge it upstream
after the patch mentioned above lands upstream via net-next.
---
 arch/arm/mach-shmobile/board-lager.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c
index a7e54e5..8f50ed2 100644
--- a/arch/arm/mach-shmobile/board-lager.c
+++ b/arch/arm/mach-shmobile/board-lager.c
@@ -96,7 +96,6 @@ static struct resource mmcif1_resources[] = {
 static struct sh_eth_plat_data ether_pdata __initdata = {
 	.phy			= 0x1,
 	.edmac_endian		= EDMAC_LITTLE_ENDIAN,
-	.register_type		= SH_ETH_REG_FAST_RCAR,
 	.phy_interface		= PHY_INTERFACE_MODE_RMII,
 	.ether_link_active_low	= 1,
 };
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] ARM: shmobile: lager: Do not use register_type field of struct sh_eth_plat_data
  2013-08-22  7:36 [PATCH] ARM: shmobile: lager: Do not use register_type field of struct sh_eth_plat_data Simon Horman
@ 2013-08-28 18:24 ` Olof Johansson
  2013-08-29  0:08   ` Simon Horman
  2013-09-10  0:26 ` Olof Johansson
  1 sibling, 1 reply; 5+ messages in thread
From: Olof Johansson @ 2013-08-28 18:24 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Aug 22, 2013 at 04:36:38PM +0900, Simon Horman wrote:
> As of 8d3214c ("sh_eth: remove 'register_type' field from 'struct
> sh_eth_plat_data'") is is no longer necessary or correct to use the
> 'register_type' field from 'struct sh_eth_plat_data' and doing so results
> in a build error.
> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> ---
> 
> Olof,
> 
> as discussed, please apply this to for-next and merge it upstream
> after the patch mentioned above lands upstream via net-next.
> ---

Thanks, applied. Please help me remember to send this upstream if I forget. :)


-Olof

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: shmobile: lager: Do not use register_type field of struct sh_eth_plat_data
  2013-08-28 18:24 ` Olof Johansson
@ 2013-08-29  0:08   ` Simon Horman
  0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-08-29  0:08 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Aug 28, 2013 at 11:24:17AM -0700, Olof Johansson wrote:
> On Thu, Aug 22, 2013 at 04:36:38PM +0900, Simon Horman wrote:
> > As of 8d3214c ("sh_eth: remove 'register_type' field from 'struct
> > sh_eth_plat_data'") is is no longer necessary or correct to use the
> > 'register_type' field from 'struct sh_eth_plat_data' and doing so results
> > in a build error.
> > 
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > 
> > ---
> > 
> > Olof,
> > 
> > as discussed, please apply this to for-next and merge it upstream
> > after the patch mentioned above lands upstream via net-next.
> > ---
> 
> Thanks, applied. Please help me remember to send this upstream if I forget. :)

Of course, I'll keep track of this.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: shmobile: lager: Do not use register_type field of struct sh_eth_plat_data
  2013-08-22  7:36 [PATCH] ARM: shmobile: lager: Do not use register_type field of struct sh_eth_plat_data Simon Horman
  2013-08-28 18:24 ` Olof Johansson
@ 2013-09-10  0:26 ` Olof Johansson
  2013-09-10  1:04   ` Simon Horman
  1 sibling, 1 reply; 5+ messages in thread
From: Olof Johansson @ 2013-09-10  0:26 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Aug 22, 2013 at 04:36:38PM +0900, Simon Horman wrote:
> As of 8d3214c ("sh_eth: remove 'register_type' field from 'struct
> sh_eth_plat_data'") is is no longer necessary or correct to use the
> 'register_type' field from 'struct sh_eth_plat_data' and doing so results
> in a build error.
> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Applied to fixes.


-Olof

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: shmobile: lager: Do not use register_type field of struct sh_eth_plat_data
  2013-09-10  0:26 ` Olof Johansson
@ 2013-09-10  1:04   ` Simon Horman
  0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-09-10  1:04 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 09, 2013 at 05:26:00PM -0700, Olof Johansson wrote:
> On Thu, Aug 22, 2013 at 04:36:38PM +0900, Simon Horman wrote:
> > As of 8d3214c ("sh_eth: remove 'register_type' field from 'struct
> > sh_eth_plat_data'") is is no longer necessary or correct to use the
> > 'register_type' field from 'struct sh_eth_plat_data' and doing so results
> > in a build error.
> > 
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> Applied to fixes.

Thanks, it will be nice to get this out of our collective hair.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-09-10  1:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22  7:36 [PATCH] ARM: shmobile: lager: Do not use register_type field of struct sh_eth_plat_data Simon Horman
2013-08-28 18:24 ` Olof Johansson
2013-08-29  0:08   ` Simon Horman
2013-09-10  0:26 ` Olof Johansson
2013-09-10  1:04   ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).