From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/16] Move common EFI stub code from x86 arch code to common location
Date: Fri, 30 Aug 2013 13:45:18 +0100 [thread overview]
Message-ID: <20130830124518.68BBA3E102A@localhost> (raw)
In-Reply-To: <1376402180.27484.12.camel@t520.redhat.com>
On Tue, 13 Aug 2013 09:56:20 -0400, Mark Salter <msalter@redhat.com> wrote:
> On Fri, 2013-08-09 at 16:26 -0700, Roy Franz wrote:
> > No code changes made, just moving functions from x86 arch directory
> > to common location.
> > Code is shared using #include, similar to how decompression code
> > is shared among architectures.
> >
> > Signed-off-by: Roy Franz <roy.franz@linaro.org>
> > ---
>
> Tested on arm64.
>
> Acked-by: Mark Salter <msalter@redhat.com>
Looks okay to me. I'm not a big fan of #including .c files, but I'm okay
with it as-is for the time being. It can be revisited later to
investigate a clean way to compile these functions as a separate .o file.
Reviewed-by: Grant Likely <grant.likely@linaro.org>
g.
next prev parent reply other threads:[~2013-08-30 12:45 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 23:26 [PATCH V3 RFC 00/16] EFI stub for ARM Roy Franz
2013-08-09 23:26 ` [PATCH 01/16] Move common EFI stub code from x86 arch code to common location Roy Franz
2013-08-13 13:56 ` Mark Salter
2013-08-30 12:45 ` Grant Likely [this message]
2013-08-09 23:26 ` [PATCH 02/16] Add system pointer argument to shared EFI stub related functions so they no longer use global system table pointer as they did when part of eboot.c. This code is now shared, so using a global variable as part of the interface is not that nice. Also, by avoiding any global variables in the ARM EFI stub, this allows the code to be position independent without requiring GOT fixups Roy Franz
2013-08-13 13:56 ` Mark Salter
2013-08-30 12:53 ` Grant Likely
2013-08-30 21:46 ` Roy Franz
2013-08-09 23:26 ` [PATCH 03/16] Rename memory allocation/free functions Roy Franz
2013-08-13 13:56 ` Mark Salter
2013-08-30 12:54 ` Grant Likely
2013-08-09 23:26 ` [PATCH 04/16] Add minimum address parameter to efi_low_alloc() Roy Franz
2013-08-13 13:56 ` Mark Salter
2013-08-30 13:01 ` Grant Likely
2013-08-30 22:12 ` Roy Franz
2013-08-30 22:55 ` Grant Likely
2013-08-09 23:26 ` [PATCH 05/16] rename __get_map() to efi_get_memory_map(), add parameter to optionally return mmap key. The mmap key is required to exit EFI boot services, and allows efi_get_memory_map() to be used for getting final memory map Roy Franz
2013-08-13 13:57 ` Mark Salter
2013-08-30 13:06 ` Grant Likely
2013-08-09 23:26 ` [PATCH 06/16] Enforce minimum alignment of 1 page on allocations. The efi_high_alloc() and efi_low_alloc() functions use the EFI_ALLOCATE_ADDRESS option to the EFI function allocate_pages(), which requires a minimum of page alignment, and rejects all other requests Roy Franz
2013-08-13 13:57 ` Mark Salter
2013-08-30 13:08 ` Grant Likely
2013-08-09 23:26 ` [PATCH 07/16] Allow efi_free() to be called with size of 0, and do nothing in that case Roy Franz
2013-08-09 23:26 ` [PATCH 08/16] Generalize handle_ramdisks() and rename to handle_cmdline_files() Roy Franz
2013-08-13 13:57 ` Mark Salter
2013-08-30 13:31 ` Grant Likely
2013-08-09 23:26 ` [PATCH 09/16] Renames in handle_cmdline_files() to complete generalization Roy Franz
2013-08-13 13:57 ` Mark Salter
2013-08-30 13:32 ` Grant Likely
2013-08-09 23:26 ` [PATCH 10/16] Move EFI_READ_CHUNK_SIZE define to shared location Roy Franz
2013-08-13 13:57 ` Mark Salter
2013-08-30 13:33 ` Grant Likely
2013-08-30 22:49 ` Roy Franz
2013-08-09 23:26 ` [PATCH 11/16] Add proper definitions for some EFI function pointers Roy Franz
2013-08-13 13:57 ` Mark Salter
2013-08-30 13:34 ` Grant Likely
2013-08-09 23:26 ` [PATCH 12/16] Fix types in EFI calls to match EFI function definitions Roy Franz
2013-08-13 13:57 ` Mark Salter
2013-08-30 13:39 ` Grant Likely
2013-08-30 23:12 ` Roy Franz
2013-08-30 23:14 ` Grant Likely
2013-08-30 23:16 ` Roy Franz
2013-08-09 23:26 ` [PATCH 13/16] resolve warnings found on ARM compile Roy Franz
2013-08-13 13:57 ` Mark Salter
2013-08-30 13:41 ` Grant Likely
2013-08-09 23:26 ` [PATCH 14/16] Add strstr to compressed string.c for ARM Roy Franz
2013-08-30 13:43 ` Grant Likely
2013-08-30 13:47 ` Russell King - ARM Linux
2013-08-30 14:02 ` Grant Likely
2013-08-30 14:16 ` Roy Franz
2013-08-09 23:26 ` [PATCH 15/16] Add EFI stub " Roy Franz
2013-08-12 14:51 ` Mark Salter
2013-08-13 0:01 ` Roy Franz
2013-08-13 14:19 ` Dave Martin
[not found] ` <CAFECyb_bZYE5tCss8u4RkO=pdpMApo=KV0L0ORMfOnYHuiNf6w@mail.gmail.com>
2013-08-14 2:07 ` Roy Franz
2013-08-30 14:36 ` Grant Likely
2013-08-31 0:35 ` Roy Franz
2013-08-09 23:26 ` [PATCH 16/16] Add config EFI_STUB for ARM to Kconfig Roy Franz
2013-08-13 13:18 ` Dave Martin
2013-08-13 17:37 ` Roy Franz
2013-08-30 11:17 ` Grant Likely
2013-08-12 14:02 ` [PATCH V3 RFC 00/16] EFI stub for ARM Mark Salter
2013-08-13 1:13 ` Roy Franz
2013-08-13 15:46 ` Mark Salter
2013-08-13 17:58 ` Roy Franz
2013-08-17 0:16 ` Roy Franz
2013-08-23 22:40 ` Roy Franz
2013-09-02 7:36 ` Matt Fleming
2013-09-02 10:33 ` Matt Fleming
2013-09-02 15:49 ` Roy Franz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130830124518.68BBA3E102A@localhost \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).