* [PATCH] iommu/arm-smmu: use devm_ioremap_resource() instead of devm_request_and_ioremap()
@ 2013-09-02 1:28 Jingoo Han
2013-09-02 8:50 ` Will Deacon
2013-09-03 9:18 ` Will Deacon
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-09-02 1:28 UTC (permalink / raw)
To: linux-arm-kernel
Use devm_ioremap_resource() because devm_request_and_ioremap() is
obsoleted by devm_ioremap_resource().
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/iommu/arm-smmu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index f417e89..31c709c 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1786,9 +1786,9 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev)
}
smmu->size = resource_size(res);
- smmu->base = devm_request_and_ioremap(dev, res);
- if (!smmu->base)
- return -EADDRNOTAVAIL;
+ smmu->base = devm_ioremap_resource(dev, res);
+ if (IS_ERR(smmu->base))
+ return PTR_ERR(smmu->base);
if (of_property_read_u32(dev->of_node, "#global-interrupts",
&smmu->num_global_irqs)) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] iommu/arm-smmu: use devm_ioremap_resource() instead of devm_request_and_ioremap()
2013-09-02 1:28 [PATCH] iommu/arm-smmu: use devm_ioremap_resource() instead of devm_request_and_ioremap() Jingoo Han
@ 2013-09-02 8:50 ` Will Deacon
2013-09-03 9:18 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2013-09-02 8:50 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Mon, Sep 02, 2013 at 02:28:39AM +0100, Jingoo Han wrote:
> Use devm_ioremap_resource() because devm_request_and_ioremap() is
> obsoleted by devm_ioremap_resource().
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/iommu/arm-smmu.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index f417e89..31c709c 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1786,9 +1786,9 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev)
> }
>
> smmu->size = resource_size(res);
> - smmu->base = devm_request_and_ioremap(dev, res);
> - if (!smmu->base)
> - return -EADDRNOTAVAIL;
> + smmu->base = devm_ioremap_resource(dev, res);
> + if (IS_ERR(smmu->base))
> + return PTR_ERR(smmu->base);
Cheers, but I've already got a patch like this queued from Julia. I was
going to send a pull request to Joerg after the merge window, since it's a
bit late in the day for things like this at the moment.
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] iommu/arm-smmu: use devm_ioremap_resource() instead of devm_request_and_ioremap()
2013-09-02 1:28 [PATCH] iommu/arm-smmu: use devm_ioremap_resource() instead of devm_request_and_ioremap() Jingoo Han
2013-09-02 8:50 ` Will Deacon
@ 2013-09-03 9:18 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2013-09-03 9:18 UTC (permalink / raw)
To: linux-arm-kernel
[Apologies if you receive this twice -- I've been having issues with email]
On Mon, Sep 02, 2013 at 02:28:39AM +0100, Jingoo Han wrote:
> Use devm_ioremap_resource() because devm_request_and_ioremap() is
> obsoleted by devm_ioremap_resource().
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/iommu/arm-smmu.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index f417e89..31c709c 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1786,9 +1786,9 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev)
> }
>
> smmu->size = resource_size(res);
> - smmu->base = devm_request_and_ioremap(dev, res);
> - if (!smmu->base)
> - return -EADDRNOTAVAIL;
> + smmu->base = devm_ioremap_resource(dev, res);
> + if (IS_ERR(smmu->base))
> + return PTR_ERR(smmu->base);
Cheers, but I've already got a patch like this queued from Julia. I was
going to send a pull request to Joerg after the merge window, since it's a
bit late in the day for things like this at the moment.
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-03 9:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-02 1:28 [PATCH] iommu/arm-smmu: use devm_ioremap_resource() instead of devm_request_and_ioremap() Jingoo Han
2013-09-02 8:50 ` Will Deacon
2013-09-03 9:18 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).