linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: pinctrl-mxs fails to parse function definitions from different .dts files
Date: Tue, 3 Sep 2013 09:50:50 +0200	[thread overview]
Message-ID: <20130903075050.GL24802@pengutronix.de> (raw)
In-Reply-To: <20130830115127.GP18729@S2101-09.ap.freescale.net>

Hello Shawn,

On Fri, Aug 30, 2013 at 07:51:29PM +0800, Shawn Guo wrote:
> On Fri, Aug 30, 2013 at 11:27:25AM +0200, Uwe Kleine-K?nig wrote:
> > while when I move the definition of i2c1 at 1 into imx28.dtsi after i2c1 at 0
> > i2c1 probes just fine and also the pinmux-functions look right:
> > 	
> > 	# grep i2c1 /sys/kernel/debug/pinctrl/80018000.pinctrl/pinmux-functions
> > 	function: i2c1, groups = [ i2c1.0 i2c1.1 ]
> > 
> > This is not intended, is it?
> 
> Sorry.  I should have documented it somewhere, but this is intended.
> The driver requires all the pin groups for given function be sorted
> together in 'reg'.
The groups for the function i2c1 are sorted, i.e. i2c1.0 comes before
i2c1.1 :-) But honestly, it's very unconvenient to require this
grouping. It makes it impossible to define i2c1.1 in myimx28machine.dts
and so a nice advantage of being able to just include the vanilla
imx28.dtsi in my external dts file goes away :-(

So I would prefer a patch that gets rid of this restriction instead of a
patch that documents it.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2013-09-03  7:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30  9:27 pinctrl-mxs fails to parse function definitions from different .dts files Uwe Kleine-König
2013-08-30 11:51 ` Shawn Guo
2013-09-03  7:50   ` Uwe Kleine-König [this message]
2013-09-04  1:14     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130903075050.GL24802@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).