linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: Move symbol export to proper location
@ 2013-09-03  7:43 Thierry Reding
  2013-09-03 20:42 ` Mike Turquette
  0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2013-09-03  7:43 UTC (permalink / raw)
  To: linux-arm-kernel

The __clk_get_flags() symbol is exported immediately following the
clk_unprepare_unused_subtree() function. This is unusual, since a symbol
export typically follows body of the function that it exports.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/clk/clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 2db08c0..b49c9ee 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -458,7 +458,6 @@ static void clk_unprepare_unused_subtree(struct clk *clk)
 			clk->ops->unprepare(clk->hw);
 	}
 }
-EXPORT_SYMBOL_GPL(__clk_get_flags);
 
 /* caller must hold prepare_lock */
 static void clk_disable_unused_subtree(struct clk *clk)
@@ -607,6 +606,7 @@ unsigned long __clk_get_flags(struct clk *clk)
 {
 	return !clk ? 0 : clk->flags;
 }
+EXPORT_SYMBOL_GPL(__clk_get_flags);
 
 bool __clk_is_prepared(struct clk *clk)
 {
-- 
1.8.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] clk: Move symbol export to proper location
  2013-09-03  7:43 [PATCH] clk: Move symbol export to proper location Thierry Reding
@ 2013-09-03 20:42 ` Mike Turquette
  0 siblings, 0 replies; 2+ messages in thread
From: Mike Turquette @ 2013-09-03 20:42 UTC (permalink / raw)
  To: linux-arm-kernel

Quoting Thierry Reding (2013-09-03 00:43:51)
> The __clk_get_flags() symbol is exported immediately following the
> clk_unprepare_unused_subtree() function. This is unusual, since a symbol
> export typically follows body of the function that it exports.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Thanks for the cleanup. Applied.

Regards,
Mike

> ---
>  drivers/clk/clk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 2db08c0..b49c9ee 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -458,7 +458,6 @@ static void clk_unprepare_unused_subtree(struct clk *clk)
>                         clk->ops->unprepare(clk->hw);
>         }
>  }
> -EXPORT_SYMBOL_GPL(__clk_get_flags);
>  
>  /* caller must hold prepare_lock */
>  static void clk_disable_unused_subtree(struct clk *clk)
> @@ -607,6 +606,7 @@ unsigned long __clk_get_flags(struct clk *clk)
>  {
>         return !clk ? 0 : clk->flags;
>  }
> +EXPORT_SYMBOL_GPL(__clk_get_flags);
>  
>  bool __clk_is_prepared(struct clk *clk)
>  {
> -- 
> 1.8.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-03 20:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-03  7:43 [PATCH] clk: Move symbol export to proper location Thierry Reding
2013-09-03 20:42 ` Mike Turquette

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).