From: Dave.Martin@arm.com (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] arm64: Align an assembler string properly
Date: Wed, 4 Sep 2013 15:50:59 +0100 [thread overview]
Message-ID: <20130904145059.GC2369@localhost.localdomain> (raw)
In-Reply-To: <CAC8NTUUdpUxfzn4_nrvMxj_otGmXROEKwio7DQ27BoMv0vwsAw@mail.gmail.com>
On Wed, Sep 04, 2013 at 06:22:44PM +0530, Radha Mohan wrote:
> Hi Catalin,
> Can you please review this?
>
> regards,
> Radha Mohan
>
> On Mon, Sep 2, 2013 at 4:18 PM, Radha Mohan <mohun106@gmail.com> wrote:
> > From: Corey Minyard <cminyard@mvista.com>
> >
> > Do a proper align and put it in the right section.
> >
> > Signed-off-by: Corey Minyard <cminyard@mvista.com>
> > ---
> > arch/arm64/mm/proc.S | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S
> > index 76d8320..1f89adc 100644
> > --- a/arch/arm64/mm/proc.S
> > +++ b/arch/arm64/mm/proc.S
> > @@ -95,10 +95,11 @@ ENTRY(cpu_do_switch_mm)
> > ret
> > ENDPROC(cpu_do_switch_mm)
> >
> > + .section ".rodata"
> > cpu_name:
> > .ascii "AArch64 Processor"
> > - .align
> >
> > + .align 3
Since cpu_name is local, not referenced, and not next to anything
noteworthy (so, unlikely to be found implicitly), I wonder why it's
needed at all.
cputable.c:cpu_table just has a C string literal instead, with the same
content.
Perhaps proc.S:cpu_name is used in some other way, but I can't see it.
The kernel still builds if it is deleted.
Cheers
---Dave
> > .section ".text.init", #alloc, #execinstr
> >
> > /*
> > --
> > 1.7.1
>
> _______________________________________________
> linaro-kernel mailing list
> linaro-kernel at lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/linaro-kernel
next prev parent reply other threads:[~2013-09-04 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 10:48 [PATCH 1/1] arm64: Align an assembler string properly Radha Mohan
2013-09-02 11:28 ` Catalin Marinas
2013-09-04 12:52 ` Radha Mohan
2013-09-04 14:50 ` Dave Martin [this message]
2013-09-05 9:05 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904145059.GC2369@localhost.localdomain \
--to=dave.martin@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).