From: jbe@pengutronix.de (Jürgen Beisert)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits
Date: Thu, 5 Sep 2013 09:12:11 +0200 [thread overview]
Message-ID: <201309050912.11106.jbe@pengutronix.de> (raw)
In-Reply-To: <201309041606.34837.marex@denx.de>
Hi Marek,
On Wednesday 04 September 2013 16:06:34 Marek Vasut wrote:
> [...]
> > +# define LRADC_CTRL0_MX28_TOUCH_DETECT_ENABLE (1 << 23)
> > +# define LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE (1 << 22)
> > +# define LRADC_CTRL0_MX28_YNNSW /* YM */ (1 << 21)
> > +# define LRADC_CTRL0_MX28_YPNSW /* YP */ (1 << 20)
> > +# define LRADC_CTRL0_MX28_YPPSW /* YP */ (1 << 19)
> > +# define LRADC_CTRL0_MX28_XNNSW /* XM */ (1 << 18)
> > +# define LRADC_CTRL0_MX28_XNPSW /* XM */ (1 << 17)
> > +# define LRADC_CTRL0_MX28_XPPSW /* XP */ (1 << 16)
>
> Why do you put this space between # and define?
Matter of taste: to visible show a difference between registers itself and
their bits inside. Its my default state to help readers to read my code.
> > [...]
> > #define LRADC_CTRL1 0x10
> > #define LRADC_CTRL1_TOUCH_DETECT_IRQ_EN (1 << 24)
> > #define LRADC_CTRL1_LRADC_IRQ_EN(n) (1 << ((n) + 16))
> > -#define LRADC_CTRL1_LRADC_IRQ_EN_MASK (0x1fff << 16)
> > +#define LRADC_CTRL1_MX28_LRADC_IRQ_EN_MASK (0x1fff << 16)
> > #define LRADC_CTRL1_LRADC_IRQ_EN_OFFSET 16
> > #define LRADC_CTRL1_TOUCH_DETECT_IRQ (1 << 8)
> > #define LRADC_CTRL1_LRADC_IRQ(n) (1 << (n))
> > -#define LRADC_CTRL1_LRADC_IRQ_MASK 0x1fff
> > +#define LRADC_CTRL1_MX28_LRADC_IRQ_MASK 0x1fff
>
> MIght just be easier to define this as
>
> LRADC....IRQ_MASK(id) (((id) == MX23) ? 0x1ff : 0x1fff)
>
> just like the MXS SSP driver does it. Then there won't be so much churn.
Nice. Will change it.
Regards,
Juergen
--
Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?| Juergen Beisert ? ? ? ? ? ? |
Linux Solutions for Science and Industry ? ? ?| http://www.pengutronix.de/ |
next prev parent reply other threads:[~2013-09-05 7:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1378299706-6742-1-git-send-email-jbe@pengutronix.de>
2013-09-04 13:01 ` [PATCH 1/5] Staging/iio/adc/touchscreen/MXS: distinguish i.MX23's and i.MX28's LRADC Juergen Beisert
2013-09-04 13:01 ` [PATCH 2/5] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits Juergen Beisert
2013-09-04 14:06 ` Marek Vasut
2013-09-05 7:12 ` Jürgen Beisert [this message]
2013-09-04 14:36 ` Dan Carpenter
2013-09-05 7:13 ` Jürgen Beisert
2013-09-04 13:01 ` [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver Juergen Beisert
2013-09-04 14:27 ` Dan Carpenter
2013-09-05 10:16 ` Jürgen Beisert
2013-09-05 10:42 ` Dan Carpenter
2013-09-05 10:51 ` Marek Vasut
2013-09-05 18:15 ` Dan Carpenter
2013-09-05 18:16 ` [patch] iio: mxs-lradc: use helper functions to simplify the code Dan Carpenter
2013-09-05 20:15 ` Fabio Estevam
2013-09-05 20:29 ` Marek Vasut
2013-09-06 8:39 ` Russell King - ARM Linux
2013-09-06 7:01 ` Jürgen Beisert
2013-09-06 7:29 ` Dan Carpenter
2013-09-04 13:01 ` [PATCH 4/5] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection Juergen Beisert
2013-09-04 13:01 ` [PATCH 5/5] Staging/iio/adc/touchscreen/MXS: Remove old touchscreen detection implementation Juergen Beisert
2013-09-04 14:37 ` Dan Carpenter
2013-09-05 7:10 ` Jürgen Beisert
2013-09-06 10:08 [RFCv2] staging/iio/adc: change the MXS touchscreen driver implementation Juergen Beisert
2013-09-06 10:08 ` [PATCH 2/5] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits Juergen Beisert
-- strict thread matches above, loose matches on Subject: below --
2013-09-09 8:03 [RFCv3] staging/iio/adc: change the MXS touchscreen driver implementation Juergen Beisert
2013-09-09 8:03 ` [PATCH 2/5] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits Juergen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309050912.11106.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).