From mboxrd@z Thu Jan 1 00:00:00 1970 From: jason@lakedaemon.net (Jason Cooper) Date: Thu, 5 Sep 2013 07:38:44 -0400 Subject: [PATCH] net: mvneta: properly disable HW PHY polling and ensure adjust_link() works In-Reply-To: <20130905102659.25a0f064@skate> References: <1378304478-21237-1-git-send-email-thomas.petazzoni@free-electrons.com> <20130904163245.GI20552@1wt.eu> <20130905051223.GB26000@1wt.eu> <20130905092808.617da416@skate> <20130905074426.GD26000@1wt.eu> <20130905102659.25a0f064@skate> Message-ID: <20130905113844.GR19598@titan.lakedaemon.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Sep 05, 2013 at 10:26:59AM +0200, Thomas Petazzoni wrote: > On Thu, 5 Sep 2013 09:44:26 +0200, Willy Tarreau wrote: > > One simpler solution for them could be to slightly modify the boot loader > > so that it sets the MAC address on the two ethernet controllers prior to > > boot. Then your code which checks if a MAC is already set will simply > > work. > > This works when the network driver is compiled 'statically' inside the > kernel. When compiled as a module, then the gatable clock of the > network interface will be gated at the end of the kernel boot, before > the mvneta module is probe. And gating the network interface clocks > means that it will loose its state, including its MAC address. So it's > not an entirely perfect solution either, but I admit that on such > platforms, the network driver is most likely compiled statically, so it > would probably suit the needs of most people. Up until sleep and standby modes are supported. Proper power savings would include gating the clock... thx, Jason.