linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/3] Target CPU=Host implementation for KVM ARM/ARM64
Date: Fri, 6 Sep 2013 10:06:23 +0100	[thread overview]
Message-ID: <20130906090623.GA30450@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <BB11B00E-5EBD-45F5-89C7-7973919F7184@suse.de>

On Fri, Sep 06, 2013 at 09:54:23AM +0100, Alexander Graf wrote:
> 
> On 06.09.2013, at 09:44, Anup Patel wrote:
> 
> > On Thu, Sep 5, 2013 at 8:21 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> >> On 5 September 2013 15:45, Anup Patel <anup.patel@linaro.org> wrote:
> >>> It will be very useful for user space if it has a method for specifying
> >>> KVM ARM/ARM64 to give a VCPU with target type suitable to underlying host
> >>> but with particular set of features.
> >>> 
> >>> In other words, user space might not be interested in having a particular
> >>> target type for VCPU but it will certainely want particular set of features
> >>> in the VCPU.
> >>> 
> >>> The patch tries to implement above described method of specifying VCPU
> >>> target CPU=Host from user space by extending the KVM_ARM_VCPU_INIT ioctl
> >>> and having a dummy target KVM_ARM_TARGET_HOST which means Target CPU
> >>> same as (or suitable to) underlying host.
> >> 
> >> I thought the consensus on the call last week was
> >> to have an ioctl for "get best CPU for this host"
> >> and then for userspace to pass that value to
> >> VCPU_INIT ?
> > 
> > I had considered having a separate ioctl for "get best CPU for this host"
> > (as per KVM call minutes) but the same thing is possible with existing
> > KVM_ARM_VCPU_INIT so why not extend this ioctl. Also, I was finding
> 
> Because it means that everything as of the INIT call is reproducible by user space. There is no way the kernel can do magic behind our back to create a vcpu that user space couldn't create the same way on a different host when you want to live migrate.
> 
> > it hard to come up with a use case where having a separate ioctl for
> > "get best CPU for this host" would be better for user space.
> 
> It can store it and migrate it as part of its migration protocol (probably hard for QEMU's current work flow, but that's QEMU's issue).

It's also better from the point of view of devicetree generation. For
example, kvmtool needs to generate the correct architected timer interrupt
numbers for the target CPU, so munging this into KVM_ARM_VCPU_INIT means we
have to go off and figure out the host CPU separately anyway.

Will

  reply	other threads:[~2013-09-06  9:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 14:45 [RFC PATCH 0/3] Target CPU=Host implementation for KVM ARM/ARM64 Anup Patel
2013-09-05 14:46 ` [RFC PATCH 1/3] ARM: KVM: Implement target CPU=Host Anup Patel
2013-09-06  8:08   ` Claudio Fontana
2013-09-05 14:46 ` [RFC PATCH 2/3] ARM64: " Anup Patel
2013-09-06  8:09   ` Claudio Fontana
2013-09-05 14:46 ` [RFC PATCH 3/3] KVM: ARM: Update documentation for KVM_ARM_VCPU_INIT ioctl Anup Patel
2013-09-06  8:05   ` Claudio Fontana
2013-09-06 10:13     ` Anup Patel
2013-09-05 14:51 ` [RFC PATCH 0/3] Target CPU=Host implementation for KVM ARM/ARM64 Peter Maydell
2013-09-06  7:44   ` Anup Patel
2013-09-06  8:54     ` Alexander Graf
2013-09-06  9:06       ` Will Deacon [this message]
2013-09-06 10:09         ` Anup Patel
2013-09-06 10:49           ` Will Deacon
2013-09-06 10:51             ` Anup Patel
2013-09-06 10:52               ` Will Deacon
2013-09-06 10:05       ` Anup Patel
2013-09-06 10:24         ` Alexander Graf
2013-09-06 10:34           ` Marc Zyngier
2013-09-06 10:38             ` Anup Patel
2013-09-06 10:34           ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130906090623.GA30450@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).