From mboxrd@z Thu Jan  1 00:00:00 1970
From: jbe@pengutronix.de (=?iso-8859-1?q?J=FCrgen_Beisert?=)
Date: Fri, 6 Sep 2013 14:30:50 +0200
Subject: [PATCH 4/5] Staging/iio/adc/touchscreen/MXS: add interrupt driven
 touch detection
In-Reply-To: <20130906122611.GT6329@mwanda>
References: <1378462123-4830-1-git-send-email-jbe@pengutronix.de>
 <1378462123-4830-5-git-send-email-jbe@pengutronix.de>
 <20130906122611.GT6329@mwanda>
Message-ID: <201309061430.50736.jbe@pengutronix.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org


On Friday 06 September 2013 14:26:11 Dan Carpenter wrote:
> On Fri, Sep 06, 2013 at 12:08:42PM +0200, Juergen Beisert wrote:
> > +static int mxs_lradc_read_ts_channel(struct mxs_lradc *lradc)
> > +{
> > +	u32 reg;
> > +	int val;
> > +
> > +	reg = readl(lradc->base + LRADC_CTRL1);
> > +
> > +	/* only channels 3 to 5 are of interest here */
> > +	if (reg & LRADC_CTRL1_LRADC_IRQ(TS_CH_YP)) {
> > +		pr_devel("!3");
>
> Gar.  I meant to comment on this the first time this patch was sent.
>
> Please remove the pr_devel() calls.  They are nonsense.

They are very helpful for development to monitor the statemachine... :) But you 
are right, I will remove them.

Regards,
Juergen

-- 
Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?| Juergen Beisert ? ? ? ? ? ? |
Linux Solutions for Science and Industry ? ? ?| http://www.pengutronix.de/  |