From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] arm: add early_ioremap support
Date: Fri, 6 Sep 2013 17:14:49 +0100 [thread overview]
Message-ID: <20130906161448.GI1946@arm.com> (raw)
In-Reply-To: <1378459158-2145-3-git-send-email-leif.lindholm@linaro.org>
On Fri, Sep 06, 2013 at 10:19:18AM +0100, Leif Lindholm wrote:
> --- a/arch/arm/kernel/setup.c
> +++ b/arch/arm/kernel/setup.c
> @@ -877,6 +878,10 @@ void __init setup_arch(char **cmdline_p)
>
> parse_early_param();
>
> +#ifdef CONFIG_EARLY_IOREMAP
> + early_ioremap_init();
> +#endif
Better with a dummy early_ioremap_init() in the header when
!CONFIG_EARLY_IOREMAP to avoid the #ifdef here.
> --- /dev/null
> +++ b/arch/arm/mm/early_ioremap.c
> @@ -0,0 +1,271 @@
> +/*
> + * early_ioremap() support for ARM
> + *
> + * Based on existing support in arch/x86/mm/ioremap.c
At a very quick look, this looks really close to the x86 implementation.
Any reason why this cannot be made generic and avoid duplication?
--
Catalin
next prev parent reply other threads:[~2013-09-06 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 9:19 [PATCH v2 0/2] Add early_ioremap()/early_memremap() support to arm Leif Lindholm
2013-09-06 9:19 ` [PATCH v2 1/2] Documentation: arm: early_ioremap/early_memremap Leif Lindholm
2013-09-06 9:28 ` Russell King - ARM Linux
2013-09-06 9:19 ` [PATCH v2 2/2] arm: add early_ioremap support Leif Lindholm
2013-09-06 16:14 ` Catalin Marinas [this message]
2013-09-10 12:02 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130906161448.GI1946@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).