linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/04] ARM: shmobile: r8a7791 SCIF support
Date: Mon, 9 Sep 2013 09:15:24 +0900	[thread overview]
Message-ID: <20130909001524.GD21921@verge.net.au> (raw)
In-Reply-To: <CACRpkdY=j_XRPd9-CV-wj9ajSDZMA1H=k8uK1T2040rmfY=R_A@mail.gmail.com>

On Fri, Sep 06, 2013 at 06:27:22PM +0200, Linus Walleij wrote:
> On Wed, Sep 4, 2013 at 5:46 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> 
> > From: Yoshikazu Fujikawa <yoshikazu.fujikawa.ue@renesas.com>
> >
> > Add SCIF serial port support to the r8a7791 SoC by
> > adding platform devices for SCIFA0 -> SCIFA5 as well
> > as SCIFB0 -> SCIFB2 and SCIF0 -> SCIF5 together with
> > clock bindings. DT device description is excluded at
> > this point since such bindings are still under
> > development.
> 
> A good way to get started with clock bindings may be to
> move the clocks to drivers/clk because in the neighboring
> drivers over there are many good examples of how to do
> this.
> 
> Again this looks like it is piling up more legacy clk
> code instead of moving to the new frameworks.
> 
> Please include Mike Turquette on future postings of the
> clk code, he's definately our best clock code reviewer.

Perhaps I was a bit hasty, but I have already queued up these changes.
And moreover I believe they are useful in their current form for
back-porting to LTSI-3.4, which I have also already done.

So on those two counts my preference would be for any enhancements
to be done as incremental patches on top of this series.

  reply	other threads:[~2013-09-09  0:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04  3:45 [PATCH 00/04] ARM: shmobile: Initial r8a7791 SoC and Koelsch board support Magnus Damm
2013-09-04  3:45 ` [PATCH 01/04] ARM: shmobile: Initial r8a7791 SoC support Magnus Damm
2013-09-06 16:21   ` Linus Walleij
2013-09-09  0:16     ` Simon Horman
2013-09-09  6:55       ` Linus Walleij
2013-09-09  7:37         ` Magnus Damm
2013-09-09  7:21     ` Magnus Damm
2013-09-09  7:45       ` Linus Walleij
2013-09-09  8:05         ` Magnus Damm
2013-09-09  9:15           ` Linus Walleij
2013-09-09 10:32             ` Magnus Damm
2013-09-18 17:20           ` Olof Johansson
2013-09-04  3:46 ` [PATCH 02/04] ARM: shmobile: r8a7791 SCIF support Magnus Damm
2013-09-06 16:27   ` Linus Walleij
2013-09-09  0:15     ` Simon Horman [this message]
2013-09-09  6:54       ` Linus Walleij
2013-09-09  7:09         ` Simon Horman
2013-09-09  7:28           ` Magnus Damm
2013-09-09  7:24     ` Magnus Damm
2013-09-04  3:46 ` [PATCH 03/04] ARM: shmobile: r8a7791 CMT support Magnus Damm
2013-09-04  3:46 ` [PATCH 04/04] ARM: shmobile: Koelsch support Magnus Damm
2013-09-04  8:38 ` [PATCH 00/04] ARM: shmobile: Initial r8a7791 SoC and Koelsch board support Simon Horman
2013-09-06  7:09   ` Simon Horman
2013-09-09  7:39     ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130909001524.GD21921@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).