public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH ] ARM: sunxi: Add Emac,SMP and Arch_timer support for sunxi A20;Add phy cnt arch timer for ARMv7 support.
Date: Wed, 11 Sep 2013 10:43:44 +0200	[thread overview]
Message-ID: <20130911084344.GH2746@lukather> (raw)
In-Reply-To: <16b7467c.1f121.141089f3d81.Coremail.coosty@163.com>

Hi Cini,

On Wed, Sep 11, 2013 at 12:05:55AM +0800, cini wrote:
> It has been tested on a Cubieboard 2. To use SMP you must set
> ARM_ARCH_TIMER and ARM_ARCH_TIMER_USE_PHYCNT when make xconfig.? If
> you have any questions or comments please feel free to contact me.
> ?Have a wonderful day!

Thanks for working on this!

You still have to work a bit on the submission part however.

First, make sure you read and follow
http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel
along with Documentation/SubmittingPatches

Basically, you should use git format-patch and git send-email to easily
contribute your patches to the right format.
Among other things, your current patches lack some files (platsmp.c,
headsmp.S, etc.), also lack the Signed-off-by tag (using your real
name).

You should also try to split the changes you're making into logical
changes.

In that case, that means that you would probably have different patches
to :
  - Add the SMP code to mach-sunxi
  - Add the SMP-related nodes to the DTSI
  - Make the modifications to the arch timers
  - And add the EMAC support

Finally, you should probably look at
http://linux-sunxi.org/Mainlining_Effort to get in sync with other
people doing sunxi-related stuff to avoid effort duplication.

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130911/03027161/attachment.sig>

  parent reply	other threads:[~2013-09-11  8:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10 16:05 [PATCH ] ARM: sunxi: Add Emac,SMP and Arch_timer support for sunxi A20;Add phy cnt arch timer for ARMv7 support cini
2013-09-10 16:18 ` cini
2013-09-10 18:48 ` Emilio López
2013-09-11  0:58   ` cini
2013-09-11  5:30     ` cini
2013-09-11  8:43 ` Maxime Ripard [this message]
2013-09-11  9:40   ` cini
2013-09-11 11:06 ` [PATCH ] ARM: sunxi: Add Emac,SMP and Arch_timer support for sunxi A20; Add " Arokux
2013-09-11 17:45 ` [PATCH ] ARM: sunxi: Add Emac,SMP and Arch_timer support for sunxi A20;Add " cini
2013-09-11 18:44   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130911084344.GH2746@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox