linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mingo@kernel.org (Ingo Molnar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] perf tools: Check libunwind for availability of dwarf parsing feature
Date: Sat, 14 Sep 2013 08:02:26 +0200	[thread overview]
Message-ID: <20130914060226.GD364@gmail.com> (raw)
In-Reply-To: <CAFrcx1nE8GUa59-5TsJxH9+deBLB-vuX2R+b8dxtgFvOX8FC7w@mail.gmail.com>


* Jean Pihet <jean.pihet@linaro.org> wrote:

> Hi Will,
> 
> On 13 September 2013 19:15, Will Deacon <will.deacon@arm.com> wrote:
> > Hi Jean,
> >
> > On Fri, Sep 13, 2013 at 06:08:41PM +0100, Jean Pihet wrote:
> >> The newly added dwarf unwinding feature [1] requires:
> >> . a recent version (>= 1.1) of libunwind,
> >> . libunwind to be configured with --enable-debug-frame.
> >>
> >> [1] http://www.spinics.net/lists/kernel/msg1598951.html
> >>
> >> Add the corresponding API test in the feature check list.
> >
> > Any reason not to merge this in with the third patch in original series? I
> > don't think it's been picked up by anybody yet, so it would make sense to
> > repost with this fixup after the merge window.
>
> Yes you are right Will repost with this patch folded into the third 
> patch, or as a fourth patch. Any preference?

I suspect it should be a separate patch, but _prior_ the patch that makes 
use of this new facility.

That way it's bisection-safe.

Thanks,

	Ingo

      reply	other threads:[~2013-09-14  6:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-13 17:08 [PATCH] perf tools: Check libunwind for availability of dwarf parsing feature Jean Pihet
2013-09-13 17:15 ` Will Deacon
2013-09-13 17:19   ` Jean Pihet
2013-09-14  6:02     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130914060226.GD364@gmail.com \
    --to=mingo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).