From mboxrd@z Thu Jan 1 00:00:00 1970 From: mingo@kernel.org (Ingo Molnar) Date: Sat, 14 Sep 2013 08:02:26 +0200 Subject: [PATCH] perf tools: Check libunwind for availability of dwarf parsing feature In-Reply-To: References: <1379092121-5981-1-git-send-email-jean.pihet@linaro.org> <20130913171503.GC14224@mudshark.cambridge.arm.com> Message-ID: <20130914060226.GD364@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Jean Pihet wrote: > Hi Will, > > On 13 September 2013 19:15, Will Deacon wrote: > > Hi Jean, > > > > On Fri, Sep 13, 2013 at 06:08:41PM +0100, Jean Pihet wrote: > >> The newly added dwarf unwinding feature [1] requires: > >> . a recent version (>= 1.1) of libunwind, > >> . libunwind to be configured with --enable-debug-frame. > >> > >> [1] http://www.spinics.net/lists/kernel/msg1598951.html > >> > >> Add the corresponding API test in the feature check list. > > > > Any reason not to merge this in with the third patch in original series? I > > don't think it's been picked up by anybody yet, so it would make sense to > > repost with this fixup after the merge window. > > Yes you are right Will repost with this patch folded into the third > patch, or as a fourth patch. Any preference? I suspect it should be a separate patch, but _prior_ the patch that makes use of this new facility. That way it's bisection-safe. Thanks, Ingo