From: drjones@redhat.com (Andrew Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: KVM: Increase max VCPUs per-Guest to 8
Date: Sat, 14 Sep 2013 13:58:47 +0200 [thread overview]
Message-ID: <20130914115847.GB2596@hawk.usersys.redhat.com> (raw)
In-Reply-To: <52330943.4090309@arm.com>
On Fri, Sep 13, 2013 at 01:46:59PM +0100, Marc Zyngier wrote:
> On 11/09/13 14:02, Anup Patel wrote:
> > Current max VCPUs per-Guest is set to 4 which is preventing
> > us from creating a Guest (or VM) with 8 VCPUs on Host (e.g.
> > X-Gene Storm SOC) with 8 Host CPUs.
> >
> > The correct value of max VCPUs per-Guest should be same as
> > the max CPUs supported by GICv2 which is 8 hence this patch
> > increases KVM_MAX_VCPUS to 8.
>
> If anything, please make it configurable just like we have on 32bit. No
> reason to impose the extra overhead on everyone.
What type of overhead are we talking about? Memory, right? as
kvm_for_each_vcpu is almost always used when iterating. But Anup says in
his v2 of this patch "can make things slower". If it's memory, then is so
much consumed by each vcpu that we shouldn't always set KVM_MAX_VCPUS
to at least the highest number that current hardware supports? Particularly
for aarch64 I think we should always be considering multi-platform with the
kernel configs.
drew
>
> Thanks,
>
> M.
>
> > Signed-off-by: Anup Patel <anup.patel@linaro.org>
> > Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
> > ---
> > arch/arm64/include/asm/kvm_host.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> > index 0859a4d..60ef29e 100644
> > --- a/arch/arm64/include/asm/kvm_host.h
> > +++ b/arch/arm64/include/asm/kvm_host.h
> > @@ -26,7 +26,7 @@
> > #include <asm/kvm_asm.h>
> > #include <asm/kvm_mmio.h>
> >
> > -#define KVM_MAX_VCPUS 4
> > +#define KVM_MAX_VCPUS 8
> > #define KVM_USER_MEM_SLOTS 32
> > #define KVM_PRIVATE_MEM_SLOTS 4
> > #define KVM_COALESCED_MMIO_PAGE_OFFSET 1
> >
>
>
> --
> Jazz is not dead. It just smells funny...
>
>
> _______________________________________________
> kvmarm mailing list
> kvmarm at lists.cs.columbia.edu
> https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
next prev parent reply other threads:[~2013-09-14 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 13:02 [PATCH] arm64: KVM: Increase max VCPUs per-Guest to 8 Anup Patel
2013-09-13 12:46 ` Marc Zyngier
2013-09-14 8:51 ` Andrew Jones
2013-09-14 11:58 ` Andrew Jones [this message]
2013-09-14 12:13 ` Marc Zyngier
2013-09-14 12:36 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130914115847.GB2596@hawk.usersys.redhat.com \
--to=drjones@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).