From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Kirkwood - Remove kirkwood_setup_wins and rely on the DT binding
Date: Tue, 17 Sep 2013 10:32:07 -0300 [thread overview]
Message-ID: <20130917133206.GB2488@localhost> (raw)
In-Reply-To: <20130916224743.GA18349@obsidianresearch.com>
Jason,
For some reason that I can't recall, the prefered style for commit logs is:
[PATCH] ARM: kirkwood: Remove kirkwood_setup_wins and rely on the DT
binding
(Yes, I know, it's just stupid nit...)
On Mon, Sep 16, 2013 at 04:47:43PM -0600, Jason Gunthorpe wrote:
> kirkwood_setup_wins is the last manual caller of mbus in kirkwood, don't
> call it for DT boards and rely on the board having a mbus node with
> a proper ranges property to setup these windows.
>
> This makes the DT self consistent, since the physical address of the
> NAND and CRYPTO are both referenced internally. The arbitary Linux
> constants KIRKWOOD_NAND_MEM_PHYS_BASE and KIRKWOOD_SRAM_PHYS_BASE
> no longer have to match the DT values.
>
> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> ---
> arch/arm/boot/dts/kirkwood-db-88f6281.dts | 5 ++++-
> arch/arm/boot/dts/kirkwood-db-88f6282.dts | 5 ++++-
> arch/arm/boot/dts/kirkwood-iconnect.dts | 5 ++++-
> arch/arm/boot/dts/kirkwood-mplcec4.dts | 5 ++++-
> arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts | 5 ++++-
> arch/arm/boot/dts/kirkwood-nsa310.dts | 5 ++++-
> arch/arm/boot/dts/kirkwood-ts219-6282.dts | 5 ++++-
> arch/arm/mach-kirkwood/board-dt.c | 1 -
> 8 files changed, 28 insertions(+), 8 deletions(-)
>
I'm trying to figure out why you're changing just these and not
all of the kirkwood device tree files, but I really can't.
Grep says these contain a nand node:
arch/arm/boot/dts/kirkwood-dockstar.dts
arch/arm/boot/dts/kirkwood-goflexnet.dts
arch/arm/boot/dts/kirkwood-guruplug-server-plus.dts
arch/arm/boot/dts/kirkwood-ib62x0.dts
arch/arm/boot/dts/kirkwood-iconnect.dts
arch/arm/boot/dts/kirkwood-iomega_ix2_200.dts
arch/arm/boot/dts/kirkwood-km_kirkwood.dts
arch/arm/boot/dts/kirkwood-mplcec4.dts
arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts
arch/arm/boot/dts/kirkwood-nsa310.dts
arch/arm/boot/dts/kirkwood-openblocks_a6.dts
arch/arm/boot/dts/kirkwood-topkick.dts
Am I missing something obvious?
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-09-17 13:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 22:47 [PATCH] arm: Kirkwood - Remove kirkwood_setup_wins and rely on the DT binding Jason Gunthorpe
2013-09-17 13:32 ` Ezequiel Garcia [this message]
2013-09-17 15:36 ` Jason Gunthorpe
2013-09-17 18:03 ` Thomas Petazzoni
2013-09-17 18:17 ` Jason Gunthorpe
2013-09-17 18:25 ` Ezequiel Garcia
2013-09-17 18:48 ` Sebastian Hesselbarth
2013-09-17 18:58 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917133206.GB2488@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).