From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mach-omap2: gpmc: Fix warning when CONFIG_ARM_LPAE=y
Date: Tue, 17 Sep 2013 16:29:19 -0700 [thread overview]
Message-ID: <20130917232918.GM9994@atomide.com> (raw)
In-Reply-To: <87y57tx6g6.fsf@linaro.org>
* Kevin Hilman <khilman@linaro.org> [130822 05:27]:
> Fabio Estevam <festevam@gmail.com> writes:
>
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > When CONFIG_ARM_LPAE=y the following build warning is generated:
> >
> > arch/arm/mach-omap2/gpmc.c:1495:4: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' [-Wformat]
> >
> > According to Documentation/printk-formats.txt '%pa' can be used to properly
> > print 'resource_size_t'.
> >
> > Reported-by: Kevin Hilman <khilman@linaro.org>
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Acked-by: Kevin Hilman <khilman@linaro.org>
Thanks applying into omap-for-v3.12/fixes.
Tony
> > ---
> > arch/arm/mach-omap2/gpmc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> > index f3fdd6a..ad6da1d 100644
> > --- a/arch/arm/mach-omap2/gpmc.c
> > +++ b/arch/arm/mach-omap2/gpmc.c
> > @@ -1491,8 +1491,8 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
> > */
> > ret = gpmc_cs_remap(cs, res.start);
> > if (ret < 0) {
> > - dev_err(&pdev->dev, "cannot remap GPMC CS %d to 0x%x\n",
> > - cs, res.start);
> > + dev_err(&pdev->dev, "cannot remap GPMC CS %d to %pa\n",
> > + cs, &res.start);
> > goto err;
> > }
prev parent reply other threads:[~2013-09-17 23:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 0:32 [PATCH] ARM: mach-omap2: gpmc: Fix warning when CONFIG_ARM_LPAE=y Fabio Estevam
2013-08-22 12:20 ` Kevin Hilman
2013-09-17 23:29 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917232918.GM9994@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).