From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: fix return value check in omap_device_build_from_dt()
Date: Tue, 17 Sep 2013 16:29:24 -0700 [thread overview]
Message-ID: <20130917232924.GN9994@atomide.com> (raw)
In-Reply-To: <87r4dg6lj2.fsf@linaro.org>
* Kevin Hilman <khilman@linaro.org> [130826 17:17]:
> Tony Lindgren <tony@atomide.com> writes:
>
> > Kevin,
> >
> > * Wei Yongjun <weiyj.lk@gmail.com> [130704 06:48]:
> >> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >>
> >> In case of error, the function omap_device_alloc() returns ERR_PTR()
> >> and never returns NULL. The NULL test in the return value check
> >> should be replaced with IS_ERR().
> >
> > Looks like this is still pending, care to take this?
>
> Acked-by: Kevin Hilman <khilman@linaro.org>
>
> Looks fine to me, since I don't have anything else in the queue, feel
> free to queue up for fixes-non-critical.
Applying into omap-for-v3.12/fixes thanks.
Tony
prev parent reply other threads:[~2013-09-17 23:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 13:42 [PATCH] ARM: OMAP: fix return value check in omap_device_build_from_dt() Wei Yongjun
2013-08-21 7:19 ` Tony Lindgren
2013-08-27 0:10 ` Kevin Hilman
2013-09-17 23:29 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917232924.GN9994@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).