* [PATCH] ARM: OMAP: fix return value check in omap_device_build_from_dt()
@ 2013-07-04 13:42 Wei Yongjun
2013-08-21 7:19 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Wei Yongjun @ 2013-07-04 13:42 UTC (permalink / raw)
To: linux-arm-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function omap_device_alloc() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
arch/arm/mach-omap2/omap_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
index 5cc9287..28e70c0 100644
--- a/arch/arm/mach-omap2/omap_device.c
+++ b/arch/arm/mach-omap2/omap_device.c
@@ -155,7 +155,7 @@ static int omap_device_build_from_dt(struct platform_device *pdev)
}
od = omap_device_alloc(pdev, hwmods, oh_cnt);
- if (!od) {
+ if (IS_ERR(od)) {
dev_err(&pdev->dev, "Cannot allocate omap_device for :%s\n",
oh_name);
ret = PTR_ERR(od);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: OMAP: fix return value check in omap_device_build_from_dt()
2013-07-04 13:42 [PATCH] ARM: OMAP: fix return value check in omap_device_build_from_dt() Wei Yongjun
@ 2013-08-21 7:19 ` Tony Lindgren
2013-08-27 0:10 ` Kevin Hilman
0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2013-08-21 7:19 UTC (permalink / raw)
To: linux-arm-kernel
Kevin,
* Wei Yongjun <weiyj.lk@gmail.com> [130704 06:48]:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function omap_device_alloc() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
Looks like this is still pending, care to take this?
Tony
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> arch/arm/mach-omap2/omap_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
> index 5cc9287..28e70c0 100644
> --- a/arch/arm/mach-omap2/omap_device.c
> +++ b/arch/arm/mach-omap2/omap_device.c
> @@ -155,7 +155,7 @@ static int omap_device_build_from_dt(struct platform_device *pdev)
> }
>
> od = omap_device_alloc(pdev, hwmods, oh_cnt);
> - if (!od) {
> + if (IS_ERR(od)) {
> dev_err(&pdev->dev, "Cannot allocate omap_device for :%s\n",
> oh_name);
> ret = PTR_ERR(od);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: OMAP: fix return value check in omap_device_build_from_dt()
2013-08-21 7:19 ` Tony Lindgren
@ 2013-08-27 0:10 ` Kevin Hilman
2013-09-17 23:29 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Hilman @ 2013-08-27 0:10 UTC (permalink / raw)
To: linux-arm-kernel
Tony Lindgren <tony@atomide.com> writes:
> Kevin,
>
> * Wei Yongjun <weiyj.lk@gmail.com> [130704 06:48]:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> In case of error, the function omap_device_alloc() returns ERR_PTR()
>> and never returns NULL. The NULL test in the return value check
>> should be replaced with IS_ERR().
>
> Looks like this is still pending, care to take this?
Acked-by: Kevin Hilman <khilman@linaro.org>
Looks fine to me, since I don't have anything else in the queue, feel
free to queue up for fixes-non-critical.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: OMAP: fix return value check in omap_device_build_from_dt()
2013-08-27 0:10 ` Kevin Hilman
@ 2013-09-17 23:29 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2013-09-17 23:29 UTC (permalink / raw)
To: linux-arm-kernel
* Kevin Hilman <khilman@linaro.org> [130826 17:17]:
> Tony Lindgren <tony@atomide.com> writes:
>
> > Kevin,
> >
> > * Wei Yongjun <weiyj.lk@gmail.com> [130704 06:48]:
> >> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >>
> >> In case of error, the function omap_device_alloc() returns ERR_PTR()
> >> and never returns NULL. The NULL test in the return value check
> >> should be replaced with IS_ERR().
> >
> > Looks like this is still pending, care to take this?
>
> Acked-by: Kevin Hilman <khilman@linaro.org>
>
> Looks fine to me, since I don't have anything else in the queue, feel
> free to queue up for fixes-non-critical.
Applying into omap-for-v3.12/fixes thanks.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-17 23:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-04 13:42 [PATCH] ARM: OMAP: fix return value check in omap_device_build_from_dt() Wei Yongjun
2013-08-21 7:19 ` Tony Lindgren
2013-08-27 0:10 ` Kevin Hilman
2013-09-17 23:29 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).