From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: OMAP2: Make MACH_OMAP3EVM select NOP_USB_XCEIV
Date: Tue, 17 Sep 2013 16:40:22 -0700 [thread overview]
Message-ID: <20130917234021.GO9994@atomide.com> (raw)
In-Reply-To: <20130904133850.GC12834@hansolo.jdub.homelinux.org>
* Josh Boyer <jwboyer@redhat.com> [130904 06:46]:
> The board-omap3evm.c file unconditionally calls usb_nop_xceiv_register but
> doesn't ensure this is built-in. This can lead to build failures like:
>
> arch/arm/mach-omap2/built-in.o: In function `omap3_evm_init':
> linux-3.12.0-0.rc0.git2.1.fc21.armv7hl/arch/arm/mach-omap2/board-omap3evm.c:686: undefined reference to `usb_nop_xceiv_register'
> make: *** [vmlinux] Error 1
>
> Make MACH_OMAP3EVM select NOP_USB_XCEIV to avoid this.
>
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> ---
> arch/arm/mach-omap2/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 3eed000..3350389 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -258,6 +258,7 @@ config MACH_OMAP3EVM
> depends on ARCH_OMAP3
> default y
> select OMAP_PACKAGE_CBB
> + select NOP_USB_XCEIV
>
> config MACH_OMAP3517EVM
> bool "OMAP3517/ AM3517 EVM board"
I think we should rather have the code in board-omap3evm.c
to be ifdef CONFIG_NOP_USB_XCEIV as it's a selectable option.
Regards,
Tony
prev parent reply other threads:[~2013-09-17 23:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 13:38 ARM: OMAP2: Make MACH_OMAP3EVM select NOP_USB_XCEIV Josh Boyer
2013-09-17 23:40 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917234021.GO9994@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).