From: gleb@redhat.com (Gleb Natapov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] aarch64: kvm: introduce CONFIG_KVM_MAX_VCPUS
Date: Wed, 18 Sep 2013 09:21:55 +0300 [thread overview]
Message-ID: <20130918062155.GF5657@redhat.com> (raw)
In-Reply-To: <20130917213428.GJ7623@lvm>
On Tue, Sep 17, 2013 at 10:34:28PM +0100, Christoffer Dall wrote:
> On Sat, Sep 14, 2013 at 02:10:56PM +0200, Andrew Jones wrote:
> > Take CONFIG_KVM_MAX_VCPUS from arm32, but set the default to 8.
> >
> > Signed-off-by: Andrew Jones <drjones@redhat.com>
> > ---
> > arch/arm64/include/asm/kvm_host.h | 7 ++++++-
> > arch/arm64/kvm/Kconfig | 11 +++++++++++
> > 2 files changed, 17 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> > index 0859a4ddd1e7d..d1af8c49a5ca4 100644
> > --- a/arch/arm64/include/asm/kvm_host.h
> > +++ b/arch/arm64/include/asm/kvm_host.h
> > @@ -26,7 +26,12 @@
> > #include <asm/kvm_asm.h>
> > #include <asm/kvm_mmio.h>
> >
> > -#define KVM_MAX_VCPUS 4
> > +#if defined(CONFIG_KVM_MAX_VCPUS)
> > +#define KVM_MAX_VCPUS CONFIG_KVM_MAX_VCPUS
> > +#else
> > +#define KVM_MAX_VCPUS 0
> > +#endif
> > +
> > #define KVM_USER_MEM_SLOTS 32
> > #define KVM_PRIVATE_MEM_SLOTS 4
> > #define KVM_COALESCED_MMIO_PAGE_OFFSET 1
> > diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig
> > index 21e90820bd23c..c9924b02e84f7 100644
> > --- a/arch/arm64/kvm/Kconfig
> > +++ b/arch/arm64/kvm/Kconfig
> > @@ -35,6 +35,17 @@ config KVM_ARM_HOST
> > ---help---
> > Provides host support for ARM processors.
> >
> > +config KVM_MAX_VCPUS
> > + int "Number maximum supported virtual CPUs per VM"
> > + depends on KVM_ARM_HOST
> > + default 8
>
> That data structure gets really big with 8 max vcpus. I think we should
> keep this at 4 for now, a quad-core VM is quite reasonable for now.
>
Which data structure? vgic? IIRC with 8 vcpus it will be something like
500 bytes bigger then it is now.
--
Gleb.
prev parent reply other threads:[~2013-09-18 6:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 12:10 [PATCH 0/3] KVM_MAX_VCPUS related changes Andrew Jones
2013-09-14 12:10 ` [PATCH 1/3] arm: kvm: clamp NR_VCPUS to MAX_VCPUS Andrew Jones
2013-09-14 12:14 ` Alexander Graf
2013-09-14 12:22 ` Marc Zyngier
2013-09-14 12:23 ` Andrew Jones
2013-09-14 12:10 ` [PATCH 2/3] arm32: kvm: rename CONFIG_KVM_ARM_MAX_VCPUS Andrew Jones
2013-09-15 9:30 ` Gleb Natapov
2013-09-16 8:09 ` Marc Zyngier
2013-09-16 8:32 ` Gleb Natapov
2013-09-16 8:49 ` Marc Zyngier
2013-09-17 21:42 ` Christoffer Dall
2013-09-24 14:09 ` [PATCH v2] " Andrew Jones
2013-09-25 19:31 ` Christoffer Dall
2013-09-26 7:54 ` Andrew Jones
2013-09-14 12:10 ` [PATCH 3/3] aarch64: kvm: introduce CONFIG_KVM_MAX_VCPUS Andrew Jones
2013-09-17 21:34 ` Christoffer Dall
2013-09-18 6:21 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918062155.GF5657@redhat.com \
--to=gleb@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).