From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: mvebu: use the main timer as clock source from DT
Date: Wed, 18 Sep 2013 18:45:09 +0200 [thread overview]
Message-ID: <20130918184509.0ad0a5be@skate> (raw)
In-Reply-To: <1379519624-4267-1-git-send-email-jean.pihet@linaro.org>
Dear Jean Pihet,
On Wed, 18 Sep 2013 17:53:44 +0200, Jean Pihet wrote:
> This commit:
> 573145f08c2b92c45498468afbbba909f6ce6135
> clocksource: armada-370-xp: Use CLOCKSOURCE_OF_DECLARE
>
> replaced a call to the driver's timer initialization by a call to
> clocksource_of_init(). However, it failed to select CONFIG_CLKSRC_OF.
>
> Fix this by selecting CONFIG_CLKSRC_OF for Armada370/XP machines.
> Without this change the kernel is stuck at: 'Calibrating delay
> loop...'.
>
> Signed-off-by: Jean Pihet <jean.pihet@linaro.org>
> Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
> arch/arm/mach-mvebu/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
> index 9eb63d7..25e6c00 100644
> --- a/arch/arm/mach-mvebu/Kconfig
> +++ b/arch/arm/mach-mvebu/Kconfig
> @@ -26,6 +26,7 @@ config MACH_ARMADA_370_XP
> select HAVE_SMP
> select CACHE_L2X0
> select CPU_PJ4B
> + select CLKSRC_OF
I disagree. This should go to drivers/clocksource/Kconfig, because it's
the clocksource driver that uses CLOCKSOURCE_OF_DECLARE. See what is
already done in drivers/clocksource/Kconfig for other drivers.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-09-18 16:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 15:53 [PATCH] arm: mvebu: use the main timer as clock source from DT Jean Pihet
2013-09-18 16:18 ` Jason Cooper
2013-09-18 16:45 ` Thomas Petazzoni [this message]
2013-09-18 16:54 ` Jason Cooper
2013-09-18 18:52 ` Jean Pihet
-- strict thread matches above, loose matches on Subject: below --
2013-09-18 18:49 Jean Pihet
2013-09-18 18:56 ` Jason Cooper
2013-09-25 10:39 ` Ezequiel Garcia
2013-09-25 23:06 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918184509.0ad0a5be@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).