linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: entry: fix tracing of ARM-private syscalls
Date: Thu, 19 Sep 2013 10:08:57 +0100	[thread overview]
Message-ID: <20130919090857.GA24866@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20130918210911.GB11181@obsidianresearch.com>

On Wed, Sep 18, 2013 at 10:09:11PM +0100, Jason Gunthorpe wrote:
> On Wed, Sep 18, 2013 at 05:12:45PM +0100, Will Deacon wrote:
> > Commit 377747c40657 ("ARM: entry: allow ARM-private syscalls to be
> > restarted") reworked the low-level syscall dispatcher to allow
> > restarting of ARM-private syscalls. Unfortunately, this relocated the
> > label used to dispatch a private syscall from the trace path, so that
> > the invocation would be bypassed altogether!
> > 
> > This causes applications to fail under strace as soon as they rely on
> > a private syscall (e.g. set_tls):
> > 
> >   set_tls(0xb6fad4c0, 0xb6fadb98, 0xb6fb1050, 0xb6fad4c0, 0xb6fb1050)
> >       = -1 ENOSYS (Function not implemented)
> > 
> > This patch fixes the label so that we correctly dispatch private
> > syscalls from the trace path.
> > 
> > Reported-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
> 
> Worked here
> 
> Tested-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

Thanks Jason, I'll send this to Russell.

> This should probably go into the 3.11 stable series too?

This problem was introduced during the merge window, so 3.11 shouldn't be
affected.

Will

      reply	other threads:[~2013-09-19  9:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-18 16:12 [PATCH] ARM: entry: fix tracing of ARM-private syscalls Will Deacon
2013-09-18 21:09 ` Jason Gunthorpe
2013-09-19  9:08   ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130919090857.GA24866@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).