From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: kirkwood: fix loss of external clock at probe time
Date: Thu, 19 Sep 2013 12:06:42 +0100 [thread overview]
Message-ID: <20130919110642.GK21013@sirena.org.uk> (raw)
In-Reply-To: <20130919114957.1fede091@armhf>
On Thu, Sep 19, 2013 at 11:49:57AM +0200, Jean-Francois Moine wrote:
> priv->extclk = devm_clk_get(&pdev->dev, "extclk");
> - if (!IS_ERR(priv->extclk)) {
> + if (IS_ERR(priv->extclk)) {
> + if (np && of_property_match_string(np, "clock-names", "extclk") >= 0)
> + return -EPROBE_DEFER;
> + } else {
This one really does seem like something the clock API ought to be
doing, either as standard or with a separate helper - essentially every
driver ought to be doing this for robustness. Doing it on general
failures is more tricky but in the specific case where we know the clock
should be present but we don't have the driver loaded yet.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130919/91152073/attachment.sig>
prev parent reply other threads:[~2013-09-19 11:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 9:49 [PATCH] ASoC: kirkwood: fix loss of external clock at probe time Jean-Francois Moine
2013-09-19 11:06 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919110642.GK21013@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox