From: jbe@pengutronix.de (Jürgen Beisert)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] Staging/iio/adc/touchscreen/MXS: provide devicetree adaption
Date: Mon, 23 Sep 2013 09:42:29 +0200 [thread overview]
Message-ID: <201309230942.29417.jbe@pengutronix.de> (raw)
In-Reply-To: <523D943D.705@kernel.org>
Hi Jonathan,
On Saturday 21 September 2013 14:42:37 Jonathan Cameron wrote:
> The device tree list has moved, so I've changed the cc.
>
> Few comments inline. Basically I'd go for longer more
> descriptive names when the abreviation isn't a really
> well known common one.
>
> Note I'm not all that familiar with device tree conventions
> so may be barking up the wrong tree ;)
>
> > [...]
> > @@ -9,13 +10,38 @@ Optional properties:
> > - fsl,lradc-touchscreen-wires: Number of wires used to connect the
> > touchscreen to LRADC. Valid value is either 4 or 5. If this property is
> > not present, then the touchscreen is -
> > disabled.
>
> Do we want that lradc prefix on these other properties?
The question is, if we want to keep it. This is the currently used binding.
> > + disabled. 5 wires is valid for i.MX28 SoC only.
> > +- fsl,ave-ctrl: number of samples per direction to calculate an average value.
> > + Allowed value is 1 ... 31, default is 4
>
> This naming seems less than informative, what about fsl,average_num_samples
> of average_count (ave isn't all that obvious an abrevaition of average).
I used already existing names from
"Documentation/devicetree/bindings/input/touchscreen/stmpe.txt".
> > +- fsl,ave-delay: delay between consecutive samples. Allowed value is
> > + 1 ... 2047. It is used if 'fsl,ave-ctrl' > 1, counts at
> > + 2 kHz and its default is 2 (= 1 ms)
>
> fsl,average_intersample_delay (I assume any limit of device tree property
> names is longer than that?)
If the parameter description in "Documentation/devicetree/bindings" is useful,
we don't need long parameter names. If there is no useful parameter
description, we will need long names ;)
Regards,
Juergen
--
Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?| Juergen Beisert ? ? ? ? ? ? |
Linux Solutions for Science and Industry ? ? ?| http://www.pengutronix.de/ |
next prev parent reply other threads:[~2013-09-23 7:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 12:22 [PATCHv5] staging/iio/adc: change the MXS touchscreen driver implementation Juergen Beisert
2013-09-19 12:22 ` [PATCH 1/7] Staging/iio/adc/touchscreen/MXS: distinguish i.MX23's and i.MX28's LRADC Juergen Beisert
2013-09-19 12:22 ` [PATCH 2/7] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits Juergen Beisert
2013-09-19 12:22 ` [PATCH 3/7] Staging/iio/adc/touchscreen/MXS: simplify register access Juergen Beisert
2013-09-19 12:22 ` [PATCH 4/7] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC touchscreen driver Juergen Beisert
2013-09-19 12:22 ` [PATCH 5/7] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection Juergen Beisert
2013-09-21 12:36 ` Jonathan Cameron
2013-09-19 12:22 ` [PATCH 6/7] Staging/iio/adc/touchscreen/MXS: Remove old touchscreen detection implementation Juergen Beisert
2013-09-19 12:22 ` [PATCH 7/7] Staging/iio/adc/touchscreen/MXS: provide devicetree adaption Juergen Beisert
2013-09-21 12:42 ` Jonathan Cameron
2013-09-23 7:42 ` Jürgen Beisert [this message]
2013-09-22 23:55 ` [PATCHv5] staging/iio/adc: change the MXS touchscreen driver implementation Marek Vasut
2013-09-23 7:55 ` Jürgen Beisert
2013-09-23 9:25 ` Lothar Waßmann
2013-09-23 10:35 ` Jürgen Beisert
2013-09-23 10:36 ` Marek Vasut
2013-09-23 11:57 ` Jürgen Beisert
2013-09-23 12:12 ` Lothar Waßmann
2013-09-23 13:24 ` Jürgen Beisert
2013-09-23 13:40 ` Lothar Waßmann
2013-09-23 14:05 ` Jürgen Beisert
2013-09-23 13:40 ` Jürgen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309230942.29417.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).