From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC V2] ARM: mm: make UACCESS_WITH_MEMCPY huge page aware
Date: Mon, 23 Sep 2013 14:21:51 +0100 [thread overview]
Message-ID: <20130923132151.GS12758@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20130923131923.GA7233@linaro.org>
On Mon, Sep 23, 2013 at 02:19:24PM +0100, Steve Capper wrote:
> On Tue, Sep 17, 2013 at 10:33:49AM +0100, Steve Capper wrote:
> > The memory pinning code in uaccess_with_memcpy.c does not check
> > for HugeTLB or THP pmds, and will enter an infinite loop should
> > a __copy_to_user or __clear_user occur against a huge page.
> >
> > This patch adds detection code for huge pages to pin_page_for_write.
> > As this code can be executed in a fast path it refers to the actual
> > pmds rather than the vma. If a HugeTLB or THP is found (they have
> > the same pmd representation on ARM), the page table spinlock is
> > taken to prevent modification whilst the page is pinned.
> >
> > On ARM, huge pages are only represented as pmds, thus no huge pud
> > checks are performed. (For huge puds one would lock the page table
> > in a similar manner as in the pmd case).
> >
> > Two helper functions are introduced; pmd_thp_or_huge will check
> > whether or not a page is huge or transparent huge (which have the
> > same pmd layout on ARM), and pmd_hugewillfault will detect whether
> > or not a page fault will occur on write to the page.
> >
> > Changes since first RFC:
> > * The page mask is widened for hugepages to reduce the number
> > of potential locks/unlocks.
> > (A knobbled /dev/zero with its latency reduction chunks
> > removed shows a 2x data rate boost with hugepages backing:
> > dd if=/dev/zero of=/dev/null bs=10M count=1024 )
> >
> > Signed-off-by: Steve Capper <steve.capper@linaro.org>
> > ---
>
> A ping to see if anyone had any questions/comments/flames :-)?
>
> Should it go into the patch system?
IIRC Nicolas wrote the original support, so he should probably be Cc'd with
this patch.
next prev parent reply other threads:[~2013-09-23 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 9:33 [RFC V2] ARM: mm: make UACCESS_WITH_MEMCPY huge page aware Steve Capper
2013-09-23 13:19 ` Steve Capper
2013-09-23 13:21 ` Russell King - ARM Linux [this message]
2013-09-23 14:10 ` Steve Capper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923132151.GS12758@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).