linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jbe@pengutronix.de (Jürgen Beisert)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv5] staging/iio/adc: change the MXS touchscreen driver implementation
Date: Mon, 23 Sep 2013 16:05:03 +0200	[thread overview]
Message-ID: <201309231605.03860.jbe@pengutronix.de> (raw)
In-Reply-To: <21056.17602.24566.144289@ipc1.ka-ro>

Hi Lothar,

On Monday 23 September 2013 15:40:18 Lothar Wa?mann wrote:
> J?rgen Beisert writes:
> > The i.MX28 manual says the LRADC delay unit is driven by a 2 kHz clock,
> > but does not say what kind of clock it is (or is derived from). I guess
> > now, this clock isn't enabled and thus the delay unit can't work. At
> > least on the MX28EVK. On your TX28 platform the clock seems enabled and
> > the delay unit can do its job and drive the state machine.
>
> The i.MX28 Ref Manual states in chapter 38.5.14 LRADC Scheduling Delay:
> | This counter operates on a 2KHz clock derived from crystal clock.
>
> Thus the clock should always be enabled.

But it isn't always on. I have now added the correct clock_get() call to the 
LRADC driver and the touchscreen works again on the MX28EVK. New patch series 
will follow. Same is required for i.MX23.

Regards,
Juergen

-- 
Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?| Juergen Beisert ? ? ? ? ? ? |
Linux Solutions for Science and Industry ? ? ?| http://www.pengutronix.de/  |

  reply	other threads:[~2013-09-23 14:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19 12:22 [PATCHv5] staging/iio/adc: change the MXS touchscreen driver implementation Juergen Beisert
2013-09-19 12:22 ` [PATCH 1/7] Staging/iio/adc/touchscreen/MXS: distinguish i.MX23's and i.MX28's LRADC Juergen Beisert
2013-09-19 12:22 ` [PATCH 2/7] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits Juergen Beisert
2013-09-19 12:22 ` [PATCH 3/7] Staging/iio/adc/touchscreen/MXS: simplify register access Juergen Beisert
2013-09-19 12:22 ` [PATCH 4/7] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC touchscreen driver Juergen Beisert
2013-09-19 12:22 ` [PATCH 5/7] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection Juergen Beisert
2013-09-21 12:36   ` Jonathan Cameron
2013-09-19 12:22 ` [PATCH 6/7] Staging/iio/adc/touchscreen/MXS: Remove old touchscreen detection implementation Juergen Beisert
2013-09-19 12:22 ` [PATCH 7/7] Staging/iio/adc/touchscreen/MXS: provide devicetree adaption Juergen Beisert
2013-09-21 12:42   ` Jonathan Cameron
2013-09-23  7:42     ` Jürgen Beisert
2013-09-22 23:55 ` [PATCHv5] staging/iio/adc: change the MXS touchscreen driver implementation Marek Vasut
2013-09-23  7:55   ` Jürgen Beisert
2013-09-23  9:25     ` Lothar Waßmann
2013-09-23 10:35     ` Jürgen Beisert
2013-09-23 10:36       ` Marek Vasut
2013-09-23 11:57         ` Jürgen Beisert
2013-09-23 12:12       ` Lothar Waßmann
2013-09-23 13:24         ` Jürgen Beisert
2013-09-23 13:40           ` Lothar Waßmann
2013-09-23 14:05             ` Jürgen Beisert [this message]
2013-09-23 13:40           ` Jürgen Beisert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201309231605.03860.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).