From mboxrd@z Thu Jan 1 00:00:00 1970 From: fweisbec@gmail.com (Frederic Weisbecker) Date: Fri, 27 Sep 2013 15:30:05 +0200 Subject: [PATCH] arm: Fix build error with context tracking calls In-Reply-To: <874n986bt9.fsf@linaro.org> References: <20130909160348.GB18975@roeck-us.net> <20130909203141.GM25647@n2100.arm.linux.org.uk> <20130909210203.GC28416@roeck-us.net> <87y574g1fi.fsf@linaro.org> <20130913170331.GA8453@somewhere> <20130914143213.GN25647@n2100.arm.linux.org.uk> <874n986bt9.fsf@linaro.org> Message-ID: <20130927133003.GA7927@localhost.localdomain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Sep 25, 2013 at 10:38:58AM -0700, Kevin Hilman wrote: > Frederic Weisbecker writes: > > > 2013/9/14, Russell King - ARM Linux : > >> On Fri, Sep 13, 2013 at 07:03:34PM +0200, Frederic Weisbecker wrote: > >>> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c > >>> index 247091b..859c8df 100644 > >>> --- a/kernel/context_tracking.c > >>> +++ b/kernel/context_tracking.c > >>> @@ -51,6 +51,15 @@ void context_tracking_user_enter(void) > >>> unsigned long flags; > >>> > >>> /* > >>> + * Repeat the user_enter() check here because some archs may be calling > >>> + * this from asm and if no CPU needs context tracking, they shouldn't > >>> + * go further. We can remove that check here once these archs support > >>> the static key > >>> + * check. > >> > >> The only (minor) comment on this is that the above would fail checkpatch, > >> but that's not a good enough reason to respin it if you've already applied > >> it IMHO. > >> > > > > Ah I haven't yet pushed that patch anywhere so I can definetly fix > > that. Thanks for the review. BTW, I initially first thought this fix > > could go through your tree but if you prefer I can push it through > > Ingo to the context tracking bits. > > > > Just tell me either way. > > Frederic, I suggest you queue it directly for v3.12-rc. Thanks, Ok, I'm doing that then, thanks you!