From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3 V3] i2c: mxs: Rework the PIO mode operation
Date: Mon, 30 Sep 2013 13:38:26 +0200 [thread overview]
Message-ID: <201309301338.27043.marex@denx.de> (raw)
In-Reply-To: <20130930112201.GE3222@katana>
Hey Wolfram,
> On Mon, Sep 30, 2013 at 01:23:54AM +0200, Marek Vasut wrote:
> > Analyze and rework the PIO mode operation. The PIO mode operation
> > was unreliable on MX28, by analyzing the bus with LA, the checks
> > for when data were available or were to be sent were wrong.
> >
> > The PIO WRITE has to be completely reworked as it multiple problems.
> > The MX23 datasheet helped here, see comments in the code for details.
> > The problems boil down to:
> > - RUN bit in CTRL0 must be set after DATA register was written
> > - The PIO transfer must be 4 bytes long tops, otherwise use
> >
> > clock stretching.
> >
> > Both of these fixes are implemented.
> >
> > The PIO READ operation can only be done for up to four bytes as
> > we are unable to read out the data from the DATA register fast
> > enough.
> >
> > This patch also tries to document the investigation within the
> > code.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
>
> Yay, there it is. Thanks, looks good to me. Will wait a few days so
> people can donate Tested-by tags.
Sorry for the delay, things're pretty hectic recently.
Are you coming to ELCE btw ?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-09-30 11:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-29 23:23 [PATCH 1/3 V2] i2c: mxs: distinguish i.MX23 and i.MX28 based I2C controller Marek Vasut
2013-09-29 23:23 ` [PATCH 2/3 V3] i2c: mxs: Rework the PIO mode operation Marek Vasut
2013-09-30 11:22 ` Wolfram Sang
2013-09-30 11:38 ` Marek Vasut [this message]
2013-09-30 11:41 ` Wolfram Sang
2013-10-04 10:29 ` Marek Vasut
2013-10-04 5:20 ` Wolfram Sang
2013-10-06 12:02 ` [PATCH 2/3 V4] " Marek Vasut
2013-10-06 13:51 ` Wolfram Sang
2013-10-06 13:54 ` Marek Vasut
2013-09-29 23:23 ` [PATCH 3/3 V3] i2c: mxs: Fix PIO mode on i.MX23 Marek Vasut
2013-10-06 13:54 ` [PATCH 1/3 V2] i2c: mxs: distinguish i.MX23 and i.MX28 based I2C controller Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309301338.27043.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).